Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hysplitdev #34

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Hysplitdev #34

merged 2 commits into from
Jun 24, 2021

Conversation

amcz
Copy link
Collaborator

@amcz amcz commented Jun 24, 2021

Fixes issue 33. Because the cdump file only stores above zero values, if the plume is not continuous, then the
cdump xarray produced by open_dataset and combine_dataset may have x or y index values that skip values -
Example -
y values of [102,103,104,105,106,108].
corresponding to latitude values of [40,40.1,40.2,40.3,40.4,40.6]
This can cause some problems when trying to contour or compare to data.
Add a check_grid_continuity and fix_grid_continuity function.

amcz added 2 commits May 26, 2021 13:32
functions which can be applied in the open_datast or combine_dataset
functions to make sure that grid is evenly spaced.
@pep8speaks
Copy link

Hello @amcz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 40:79: E231 missing whitespace after ','
Line 40:80: E501 line too long (94 > 79 characters)
Line 64:62: W291 trailing whitespace
Line 87:18: E701 multiple statements on one line (colon)
Line 88:9: E701 multiple statements on one line (colon)
Line 663:80: E501 line too long (80 > 79 characters)
Line 666:60: W291 trailing whitespace
Line 790:18: E701 multiple statements on one line (colon)
Line 791:9: E701 multiple statements on one line (colon)
Line 793:1: E302 expected 2 blank lines, found 1
Line 796:46: W291 trailing whitespace
Line 798:1: E302 expected 2 blank lines, found 1
Line 800:35: E701 multiple statements on one line (colon)
Line 811:37: E231 missing whitespace after ','
Line 811:42: E231 missing whitespace after ','
Line 813:30: E231 missing whitespace after ','
Line 813:40: E231 missing whitespace after ','
Line 814:47: E231 missing whitespace after ','
Line 814:52: E231 missing whitespace after ','
Line 814:63: W291 trailing whitespace
Line 815:48: E231 missing whitespace after ','
Line 815:53: E231 missing whitespace after ','
Line 815:64: W291 trailing whitespace
Line 816:41: E231 missing whitespace after ','
Line 817:41: E231 missing whitespace after ','
Line 818:34: E231 missing whitespace after ','
Line 818:40: E231 missing whitespace after ','
Line 818:54: W291 trailing whitespace
Line 819:47: E231 missing whitespace after ','
Line 819:52: E231 missing whitespace after ','
Line 819:63: W291 trailing whitespace
Line 820:48: E231 missing whitespace after ','
Line 820:53: E231 missing whitespace after ','
Line 820:64: W291 trailing whitespace
Line 824:1: E302 expected 2 blank lines, found 1
Line 835:56: E231 missing whitespace after ','
Line 836:56: E231 missing whitespace after ','
Line 837:17: E225 missing whitespace around operator
Line 837:21: E701 multiple statements on one line (colon)
Line 838:17: E225 missing whitespace around operator
Line 838:21: E701 multiple statements on one line (colon)
Line 856:80: E501 line too long (85 > 79 characters)
Line 871:9: E116 unexpected indentation (comment)
Line 871:9: E265 block comment should start with '# '
Line 872:9: E116 unexpected indentation (comment)
Line 872:9: E265 block comment should start with '# '
Line 873:9: E116 unexpected indentation (comment)
Line 873:9: E265 block comment should start with '# '
Line 874:9: E116 unexpected indentation (comment)
Line 874:9: E265 block comment should start with '# '
Line 875:9: E116 unexpected indentation (comment)
Line 875:9: E265 block comment should start with '# '
Line 876:9: E116 unexpected indentation (comment)
Line 876:9: E265 block comment should start with '# '
Line 877:9: E116 unexpected indentation (comment)
Line 877:9: E265 block comment should start with '# '

@amcz amcz merged commit 6a8c88c into development Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants