Develop satellite

[dwfncar]

No description provided.

[zmoon]

Hi @dwfncar, I resolved the merge conflict but am not able to push. Maybe if you "Allow edits by maintainers" in the PR somewhere?

(Note that develop and stable in the NCAR fork are a bit behind.)

[dwfncar]

Don't see many options in the PR itself. I've added you as a maintainer to the NCAR/monetio fork. Can you try to merge the conflict after accepting the repo invite? thanks, David

…

On Mon, Jul 25, 2022 at 12:15 PM Zachary Moon ***@***.***> wrote: Hi @dwfncar <https://github.com/dwfncar>, I resolved the merge conflict but am not able to push. Maybe if you "Allow edits by maintainers" in the PR somewhere? — Reply to this email directly, view it on GitHub <#71 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALUCLE67RZZVF77FNVVC2DVV3KUJANCNFSM54S7CVHQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[zmoon]

@dwfncar it is supposed to be like this but maybe it is different since the NCAR fork is under an org not a personal account

[dwfncar]

I don't have that option. I think it needs to be a user-owned fork instead of institutional.

…

On Tue, Jul 26, 2022 at 12:44 PM Zachary Moon ***@***.***> wrote: @dwfncar <https://github.com/dwfncar> it is supposed to be like this <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork> but maybe it is different since the NCAR fork is under an org not a personal account — Reply to this email directly, view it on GitHub <#71 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALUCLGSW5E2WUNWK3JOMYTVWAWXFANCNFSM54S7CVHQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[zmoon]

Initial comments:

• can you modify the hdfio test so that the test file is deleted after it is complete?
• pyhdf is currently not a required dep and I would prefer to keep it that way. Possible resolutions include:
  • modify the hdfio module so that the module-level import is not needed (within functions, you could use the _import_required helper seen in geoms reader)
• if hdfio is going to be the only module, we could probably remove the hdf directory
• for the new readers, is it possible to get tiny test files so that we can test them?
  • if not, please prepend _ and append mm to the module names

[zmoon]

Is fv3raqms reader supposed to be in this PR?

[mebruckner]

No, I was keeping that one in house as I don't think FV3-RAQMS is really public. To my knowledge we aren't currently producing forecasts and are just doing a bunch of experiments. I accidentally pushed my copy of the driver to the Melodies-Monet develop_satellite branch without the fv3ramqs reader syntax commented out.

…

________________________________ From: Zachary Moon ***@***.***> Sent: Friday, July 29, 2022 2:32 PM To: noaa-oar-arl/monetio ***@***.***> Cc: Maggie Bruckner ***@***.***>; Mention ***@***.***> Subject: Re: [noaa-oar-arl/monetio] Develop satellite (PR #71) Is fv3raqms reader supposed to be in this PR? — Reply to this email directly, view it on GitHub<#71 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALR7L5IAOHKZCL4B76PBNNLVWQWUDANCNFSM54S7CVHQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[zmoon]

omps_limb removed on request of @mebruckner

[zmoon]

I didn't look at the details of the two modules we are leaving "hidden". If at some point we want to make them public in monetio I will take a closer look.