-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more strict about RRFS-CMAQ reader PM2.5 merge #79
Conversation
The Python 3.6 run here was getting xarray 0.18.2, which has a different message in this situation. But now accounted for. |
@rschwant if you can take a quick look at some point that would be great |
"""For two ``xr.Dataset``s, try ``left.merge(right, compat="equals", join="exact")``. | ||
If it fails, print informative debugging messages and re-raise. | ||
Otherwise, return the result. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | |
`right_name` is used for context in the error messages if provided. | |
""" |
This looks good to me. I like the detail of the error messages, so that it is really clear when something goes wrong. Was Jianping able to fix the float issue in his scripts, so that these files can merge properly now? |
Thanks @rschwant
I haven't gotten an update on that. I had the same issue with some RRFS-CMAQ output from Patrick, and I did some pre-processing using |
Fixes #78