Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more strict about RRFS-CMAQ reader PM2.5 merge #79

Merged
merged 5 commits into from
Sep 15, 2022

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Aug 18, 2022

Fixes #78

  • test of this exception handling

@zmoon
Copy link
Member Author

zmoon commented Sep 2, 2022

The Python 3.6 run here was getting xarray 0.18.2, which has a different message in this situation. But now accounted for.

@zmoon zmoon marked this pull request as ready for review September 2, 2022 21:21
@zmoon
Copy link
Member Author

zmoon commented Sep 2, 2022

@rschwant if you can take a quick look at some point that would be great

"""For two ``xr.Dataset``s, try ``left.merge(right, compat="equals", join="exact")``.
If it fails, print informative debugging messages and re-raise.
Otherwise, return the result.
"""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""
`right_name` is used for context in the error messages if provided.
"""

@rschwant
Copy link
Contributor

This looks good to me. I like the detail of the error messages, so that it is really clear when something goes wrong. Was Jianping able to fix the float issue in his scripts, so that these files can merge properly now?

@zmoon
Copy link
Member Author

zmoon commented Sep 13, 2022

Thanks @rschwant

Was Jianping able to fix the float issue in his scripts, so that these files can merge properly now?

I haven't gotten an update on that. I had the same issue with some RRFS-CMAQ output from Patrick, and I did some pre-processing using ds = ds.merge(ds_pm, join="exact", compat="override"), which afaik at least checks that the index shapes match.

@zmoon zmoon merged commit a47b671 into noaa-oar-arl:develop Sep 15, 2022
@zmoon zmoon deleted the rrfs branch May 26, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants