Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pressure variables in RAQMS reader #85

Merged
merged 4 commits into from
Oct 25, 2022
Merged

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Sep 19, 2022

@zmoon zmoon marked this pull request as ready for review September 26, 2022 23:58
@zmoon
Copy link
Member Author

zmoon commented Sep 27, 2022

@mebruckner @rschwant does this look ok? I based the renames on the ones of @rschwant .

@mebruckner
Copy link
Contributor

@zmoon It looks good to me. I can test it and update the raqms melodies-monet commit to reflect this change.

@zmoon
Copy link
Member Author

zmoon commented Sep 29, 2022

@mebruckner that would be great, thanks

@rschwant
Copy link
Contributor

rschwant commented Oct 3, 2022

Yes, @zmoon this looks good to me.

@zmoon
Copy link
Member Author

zmoon commented Oct 25, 2022

@mebruckner I'm going to merge this, if you find an issue we can address in another PR.

@zmoon zmoon merged commit 288c599 into noaa-oar-arl:develop Oct 25, 2022
@zmoon zmoon deleted the raqms branch October 25, 2022 16:51
@zmoon
Copy link
Member Author

zmoon commented Oct 25, 2022

CI failures upon merge (though passing before) due to:

  • pytest 7.2 release breaking pytest-xdist
  • EPA AQS URLs erroring in link check apparently due to their server not supporting OpenSSL 3
    • e.g.
      (tutorial/aqs_pams: line 27) broken https://aqs.epa.gov/aqsweb/airdata/download_files.html - HTTPSConnectionPool(host='aqs.epa.gov', port=443): Max retries exceeded with url: /aqsweb/airdata/download_files.html (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1129)')))
    • seems this is affecting the AQS test as well (232e0e4):
      FAILED tests/test_aqs.py::test_aqs - requests.exceptions.SSLError: HTTPSConnectionPool(host='aqs.epa.gov', port=443): Max retries exceeded with url: /aqsweb/airdata/daily_PM10SPEC_2019.zip (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1131)')))

@zmoon zmoon mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants