Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traj.py #9

Merged
merged 30 commits into from
Apr 9, 2020
Merged

traj.py #9

merged 30 commits into from
Apr 9, 2020

Conversation

aring1988
Copy link
Contributor

Traj.py hysplit trajectory reader added

@pep8speaks
Copy link

pep8speaks commented Apr 9, 2020

Hello @aring1988! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 3:80: E501 line too long (83 > 79 characters)

Line 89:80: E501 line too long (85 > 79 characters)
Line 108:80: E501 line too long (81 > 79 characters)
Line 112:80: E501 line too long (93 > 79 characters)
Line 148:49: W605 invalid escape sequence '\s'
Line 148:80: E501 line too long (92 > 79 characters)

Line 11:1: E722 do not use bare 'except'
Line 44:80: E501 line too long (97 > 79 characters)
Line 45:80: E501 line too long (159 > 79 characters)
Line 46:80: E501 line too long (155 > 79 characters)
Line 54:80: E501 line too long (119 > 79 characters)
Line 68:14: E128 continuation line under-indented for visual indent
Line 69:14: E128 continuation line under-indented for visual indent
Line 70:14: E128 continuation line under-indented for visual indent
Line 71:14: E128 continuation line under-indented for visual indent
Line 72:14: E128 continuation line under-indented for visual indent
Line 73:14: E128 continuation line under-indented for visual indent
Line 74:14: E128 continuation line under-indented for visual indent
Line 78:16: E128 continuation line under-indented for visual indent
Line 79:16: E128 continuation line under-indented for visual indent
Line 80:16: E128 continuation line under-indented for visual indent
Line 81:16: E128 continuation line under-indented for visual indent
Line 82:16: E128 continuation line under-indented for visual indent
Line 83:16: E128 continuation line under-indented for visual indent
Line 227:9: E722 do not use bare 'except'

Line 27:80: E501 line too long (94 > 79 characters)

Comment last updated at 2020-04-09 20:12:35 UTC

Copy link
Member

@bbakernoaa bbakernoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this. Just thinking if someone adds a different trajectory model in the future. Something like hytraj.py

@bbakernoaa
Copy link
Member

@aring1988 please make sure to add this to the init.py in monetio/models add it to the import in monetio/init.py

@bbakernoaa
Copy link
Member

looking good @aring1988 Merging

@bbakernoaa bbakernoaa merged commit f75723d into noaa-oar-arl:development Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants