Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py_sources build layer doesn't actually build all python dependencies #33

Closed
hellkite500 opened this issue Sep 7, 2020 · 0 comments
Closed

py_sources build layer doesn't actually build all python dependencies #33

hellkite500 opened this issue Sep 7, 2020 · 0 comments
Assignees
@hellkite500

Comments

@hellkite500
Copy link
Member

DMOD/docker/py_sources/py_sources.Dockerfile

Line 10 in d149f09

RUN mkdir /DIST && pip download --no-cache-dir --destination-directory /DIST -r /nwm_service/requirements.txt

The referenced line has pip download the required depdencies, but if these downloads come in sdist form, they are not built into wheels. When a downstream service requires one of the source depdencies, it attempts to build it, but doesn't have the correct tool chain in the image file system to build (i.e. scheduler-service requires cryptography, which requires cffi which is only a source distribution, so the scheduler-sercvice attempts to build the source and fails.)
@hellkite500 hellkite500 self-assigned this Sep 7, 2020
hellkite500 added a commit to hellkite500/DMOD that referenced this issue Sep 7, 2020
@hellkite500
Make sure py-sources builds all source dependencies as wheels, fixes N…
b6fa7ff 
…OAA-OWP#33
@hellkite500 hellkite500 mentioned this issue Sep 7, 2020
Merged
8 tasks
stcui007 pushed a commit to stcui007/DMOD that referenced this issue Sep 9, 2020
@hellkite500 @stcui007
Revised commit for JSON Schema
4604baa 
Make sure py-sources builds all source dependencies as wheels, fixes NOAA-OWP#33
@stcui007 stcui007 mentioned this issue Sep 9, 2020
Merged
17 tasks
hellkite500 added a commit to stcui007/DMOD that referenced this issue Sep 9, 2020
@hellkite500
Revised commit for JSON Schema
90bb858 
Make sure py-sources builds all source dependencies as wheels, fixes NOAA-OWP#33
hellkite500 added a commit that referenced this issue Sep 9, 2020
@hellkite500
Revised commit for JSON Schema
e8b0036 
Make sure py-sources builds all source dependencies as wheels, fixes #33
christophertubbs pushed a commit to christophertubbs/DMOD that referenced this issue Jan 24, 2023
@hellkite500 @robertbartel
Make sure py-sources builds all source dependencies as wheels, fixes N…
6aaa10c 
…OAA-OWP#33
christophertubbs pushed a commit to christophertubbs/DMOD that referenced this issue Jan 24, 2023
@hellkite500
Revised commit for JSON Schema
8b08ae4 
Make sure py-sources builds all source dependencies as wheels, fixes NOAA-OWP#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellkite500 hellkite500

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hellkite500