Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nim v2: round 4 #29

Merged
merged 30 commits into from
Apr 25, 2023
Merged

nim v2: round 4 #29

merged 30 commits into from
Apr 25, 2023

Conversation

noahehall
Copy link
Owner

@noahehall noahehall commented Apr 17, 2023 •
edited
Loading

  • dont merge this without updating the doc comments
    • think you need an empty # between lines
  • update modifying compiler switches should force invalidation of all caches nim-lang/Nim#21717 with resolution to syncing test runs across environments
    • running testament all in a fresh clone did not fail tests locally
      • it has to be an environment discrepancy between local & CI, perhaps theres something in ~/ dir or in nims search paths where shiz is cached
        • running in docker would circumvent this issue but we should uncover the underlying problem here
    • see linked issue

@noahehall noahehall changed the title nim v2: everything async nim v2: async/parallel Apr 17, 2023
@noahehall noahehall force-pushed the nimv2 branch 2 times, most recently from e21d92c to b4e05b8 Compare April 19, 2023 11:29
@noahehall
nim in action notes (#30)
31bb9b2 
* pg40

* 49

* further decompose files

* 59

* 70

* 73: object variants

* move object variants into traitsAdts

* object variant

* 80

* 103

* 112

* tables are just arrays

* lol tables !== std/tables

* collections

* 113

* updates

* 117

* fix pre-commit not failing on test error

* pre-commit try 2

* pre-commit try 3

* 120

* 132

* 133

* 139

* 150

* 160

* updates

* updates

* hide unhandled errors with push

* add threadproxy

* 173

* update config options and fix deprecation errors

* set parallelbuild to 1 in CI

* add futureLogging

* update config switches

* update tests/config switches

* update config comments

* 202

* add todo
@noahehall
add ffi
5c2cc99
@noahehall
test with ci flag in commit hook
bd167ad
@noahehall
update config switches and fix errors
ed24679
@noahehall
disable futurelogging: fails in CI
92916d7
@noahehall
wierd CI failures not reproducing locally
34ac127
@noahehall
disable holeEnumConv as error on 1.6.12
0648fd9
@noahehall
disabling shiz on nim1.6.12 cuz CI errors
35a0c23
@noahehall
rm -rf ~/.cache/nim/* and verify pre-commit doesnt fail
c970033
@noahehall
enable future logging in v2 and only enable styleCheck:error in dev
3eb0e6f
@noahehall
fix
aab055e
@noahehall
haha got it
7b572dd
@noahehall
move castsizes to v2
2d654c9
@noahehall
Copy link
Owner Author

haha i bet it's the testament cache files and not the nim cache that needs to be invalidated

@noahehall noahehall changed the title nim v2: async/parallel nim v2: async/parallel + booknotes Apr 24, 2023
@noahehall noahehall changed the title nim v2: async/parallel + booknotes nim v2: round 4 Apr 24, 2023
@noahehall
Nimv2 config strict: error fixes (#31)
68170c5 
* fixing errors one-by-one

* readd workflow_dispatch to ci

* v2 no errors

* 1.6.12 no errors
@noahehall noahehall mentioned this pull request Apr 25, 2023
Open
@noahehall noahehall merged commit 8a5fd95 into develop Apr 25, 2023
@noahehall noahehall deleted the nimv2 branch April 25, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@noahehall