[master] setup tailwindcss #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
noahgsolomon
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Caution! Tailwind CSS comes with some set of base styles which are not playing well with the existing stylesheets. I tried to scope Tailwind styles to a certain component but unfortunately that's not possible at the moment. The only option is to update our existing styles to use TW once this PR is merged.
There are numerous areas of improvement for instance, a better ESLint configuration, more generic components like buttons and inputs, adding an .editorconfig so that the spacings and code style remains the same for everyone. I'll start creating issues for the same.
Coming to the changes:
Ignore everything else and focus on the JSX for now.
Instead of using stylesheets we now use utility classes.
For example,
flex-colis forflex-direction: columnpx-5ispadding-left: 20px; padding-right: 20pxSome styles are repeated but they should have been separate components in the first place. It gets easier once you get a hang of it. Here's the documentation for Tailwind