Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: Remove download_url #9

Closed
wants to merge 2 commits into from

Conversation

msabramo
Copy link
Contributor

IIRC download_url is not so useful anymore because pip much prefers to install from PyPI and will refuse to download from external places without special options.

And that URL was not valid anyway.

noahmorrison and others added 2 commits January 22, 2015 23:47
Suggested/wanted by msabramo on github.

closes noahmorrison#6
IIRC download_url is not so useful anymore because pip much prefers to install from PyPI and will refuse to download from external places without special options. 

And that URL was not valid anyway.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.85% when pulling e808bd8 on msabramo:patch-3 into 00a10d4 on noahmorrison:master.

@noahmorrison
Copy link
Owner

I tried to merge this (along with #7 and #8), but it messed with the git history (conflicts, and three merges on top of each other aren't pretty). I rebased back to the original, which I know is a terrible thing but that's what I get for trying to auto merge. If you feature branch #7 #8 #9 all together, I'll merge them in. Or if you want I'll do it for you.

Thanks for helping me understand pypi a little more though, I really have no idea what I'm doing in terms of that.

@msabramo
Copy link
Contributor Author

Yikes! Sorry that it caused you so much trouble.

Usually GitHub will tell you there are merge conflicts and won't let you merge. Usually the maintainer (you in this case) would then politely ask the contributor to fix the merge conflicts and rebase.

So usually the burden is on the contributor to make it merge cleanly so that you can just click the button and it works.

@msabramo
Copy link
Contributor Author

See #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants