[Feature] Add the ability to keep unknown tags #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new option `keep` (default: False) to `chevron.renderer.render()` that allows for unknown tags to be kept in the returned string for later processing, eg: `eval()`.
|
Seems like a nice feature, would you mind adding some unit tests for this? Take a look at the test_spec.py file and let me know if you need any help. |
The first test checks that tags are kept. Including that fact that kept tags are normalised. The second test checks that tags from partials are kept.
|
LGTM, Thanks for adding those! I really do want to cleanup the parameter passing at some point, but that's not necessarily this PR's fault |
|
Hey @noahmorrison . This seems like not yet released feature. Would you mind to make one please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option
keep(default: False) tochevron.renderer.render()that allows for unknown tags to be kept in the returned string for later processing, eg:eval().