12 fix bug where if a pseudogene performs better than all real hits that the default pvalue threshold is set to zero #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calculation with epsilon offset so that fdr will be either the min or max with the epsilon. also allows no nonzero results in the case where the direction is none. included tests as well
noamteyssier
deleted the
12-fix-bug-where-if-a-pseudogene-performs-better-than-all-real-hits-that-the-default-pvalue-threshold-is-set-to-zero
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some(Direction::Less)Some(Direction::Greater)None.This makes it so the fdr threshold is just out of range in the directional tests, and will be just out of range in the classic pvalue test but will be guaranteed non-negative.