Upstream #10
Merged
Upstream #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we've already got a banner component, we follow the convention of using one CSS file per component. We also reduce the number of lines in the huge layout.scss file. Now the sections in layout.scss from "17" to "19", just like they jump from "08" to "10".
After upgrading to Chrome/Chromium 101, the test "Cross-Site Scripting protection banner URL" was failing with the message: Element <a>...</a> is not clickable (...) Other element would receive the click: <div class="banner" style="background-color:#FF0000;">...</ div> The reason was that, when using the structure of a link with one <h2> and one <h3> inside, previous versions of Chrome/Chromium considered the margin between the <h2> and the <h3> part of the link. Version 101 does the same thing Firefox does and so clicking on the space between the <h2> and the <h3> doesn't result in clicking the link. In order to keep the previous behavior, we're adding a `display: block` tag to a link. Note that, in the future, we might change the structure of the banner, since using <h3> as a subheading is discouraged by the W3C, and we aren't sure about the usability of making the whole banner clickable. But, for now, we're just fixing the issue so our test suite is green again.
Bump Rails to 5.2.7.1
Allow send newsletters with images
Fix margins on header content
Update deploy-secrets.yml.example
Monitor CONSUL with monit
Improve subnavigation styles on mobile screens
Fix deployment error after adding monit
Fix link to comments on admin view for debates
Add new tags on legislation markdown
Fix subnavigation dropdown menu styles
Fix homepage feeds participation layout
Update custom NL text
The condition @budget.show_money? is inside budgets/ballot/progress_bar partial. So, is no necessary in this view.
Add unsubscribe info on system emails
Fix layout styles
Replace budget feeds date phase
Show participation not allowed message on mobile
The data-toggle ids should remain on the same line to work.
Add background color to mobile menu
microweb10
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives