Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot Insert Text to Canvas Cards with Banner 2.0.1 Beta Enabled #122

Closed
jr-xing opened this issue Sep 18, 2023 · 4 comments
Closed

Comments

@jr-xing
Copy link

jr-xing commented Sep 18, 2023

It seems that when the banner v2 beta is enabled, I can no longer add text in the canvas cards. Specifically, I can type in a card, but once I click somewhere else or start a new line, the previously entered text will be completely gone. Banner v1 doesn't cause this problem though.

banner

System info:

	Obsidian version: v1.4.13
	Installer version: v1.4.13
	Operating system: Windows 10 Education 10.0.23545
	Login status: logged in
	Catalyst license: insider
	Insider build toggle: on
	Live preview: on
	Legacy editor: off
	Base theme: dark
	Community theme: none
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 2
	Plugins enabled: 2
		1: Obsidian42 - BRAT v0.7.0
		2: Banners v2.0.1-beta
@CrackJackFlood
Copy link

Can confirm

@noatpad
Copy link
Owner

noatpad commented Sep 19, 2023

Oh interesting, I guess the canvas cards uses CM6 underneath, so it's trying to do the checks as if it were an editing view pane. Gonna add some safeguards to keep banners out of canvas files in that case

@jr-xing jr-xing changed the title [Bug] Cannot Insert Text to Canvas Cards in Banner 2.0.1 beta [Bug] Cannot Insert Text to Canvas Cards with Banner 2.0.1 Beta Enabled Sep 19, 2023
@noatpad
Copy link
Owner

noatpad commented Sep 20, 2023

@noatpad noatpad closed this as completed Sep 20, 2023
@stankovictab
Copy link

This issue is still present in 2.0.5-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants