Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner spills into page with new window feature #67

Open
anvimea opened this issue Jul 16, 2022 · 5 comments
Open

Banner spills into page with new window feature #67

anvimea opened this issue Jul 16, 2022 · 5 comments

Comments

@anvimea
Copy link

anvimea commented Jul 16, 2022

As of Obsidian 0.15.6, you can pop out Obsidian pages as separate windows. When trying this feature out, I noticed my windowed pages with banners looked rather off.

Some examples, in Reading & Editing mode:

Obsidian_BT8olNW4LB

Obsidian_deN8wTiJZN

Windows 10, Obsidian 0.15.6, on the latest Banners release.

While I think it actually adds a cool aesthetic to my pages, it probably will distract for others 😅

@Anthony-Leo-368
Copy link

Same issue I have met when I choose Move to new window

Xnip2022-08-19_23-46-31

Things go wrong like this

Xnip2022-08-19_23-46-40


System: MacOS Monterey 12.5
Obsidian: v0.15.9
Banners: 1.3.3

@CabbageCanFly
Copy link

I shared a sort of hacky fix in another ticket with this issue: #61 (comment)

@jessycormier
Copy link

Small update: Obsidian 1.0.0 release has these same issues and will be pulled out of windows. The banner seems to take 100vh (100% view height). Most likely just need some tweaks to the new system Obisidan has for themes to resolve.

@ironhak
Copy link

ironhak commented Oct 3, 2023

Is the developer aware of this?

@noatpad
Copy link
Owner

noatpad commented Oct 4, 2023

Hello and yes! In the v2 beta refactor I'm working on, it actually doesn't present this problem anymore; but there's a similar bug where the banner isn't added into the window until a change to the file is made. I've been looking into that bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants