Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut Headline problem #56

Closed
Qrizzz opened this issue May 28, 2020 · 4 comments
Closed

Shortcut Headline problem #56

Qrizzz opened this issue May 28, 2020 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Qrizzz
Copy link

Qrizzz commented May 28, 2020

I use the shortcuts + 16 to create a headline. When I do this before entering text the Ursine theme somehow moves the hashtags for the headline a line below or above the cursor input.

It’s hard to explain. Here are some screenshots before hitting the shortcut and after (left side normal view, right side source code view).

before
after

I have no clue why this is happening or if it’s just me. Other themes seem to have no problem.

@Konfido
Copy link
Contributor

Konfido commented Jun 9, 2020

Same here.

@noatpad
Copy link
Owner

noatpad commented Jun 22, 2020

(Pardon the late reply, college semester got real busy this time around)

But it's also happening on my end, but I honestly have no idea what might be causing it. It's definitely the theme, because every other theme works fine with me. How odd that a stylesheet is causing this...

@noatpad noatpad added bug Something isn't working help wanted Extra attention is needed labels Jun 22, 2020
@Qrizzz
Copy link
Author

Qrizzz commented Jun 22, 2020

I think it is due to the position: absolute in h1::before (Line 423)

I had a look at some other Themes that outdent the headline information. They use ::before pseudo-element and negative margin. I managed to change it in the the generated css for myself. I am sure you had something in mind with the absolute position and I don’t know for sure if my “solution” does not break anything else.

noatpad added a commit that referenced this issue Jun 23, 2020
Fix headline sign problem and add on-focus effect (fix #56)
@noatpad
Copy link
Owner

noatpad commented Jun 23, 2020

Yeah, it was that! I think back then I had an unorthodox way of styling that part, which is why I used ::after; but I forgot about it afterwards. Konfido's PR was enough to fix things and it'll be up in the next release once I get things together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants