Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested JSON tree print #3

Closed
TMsangohan opened this issue Nov 24, 2019 · 5 comments
Closed

Nested JSON tree print #3

TMsangohan opened this issue Nov 24, 2019 · 5 comments

Comments

@TMsangohan
Copy link
Collaborator

The print tree method you used in apace does not work completely properly if the nesting level is larger than 3. I have a solution, which is the implementation of the linux tree command in python but applied to dictionaries.

Should we add it?

@felix-andreas
Copy link
Member

felix-andreas commented Nov 24, 2019

Sound great. Please do a PR.

We could definitively add this functionality to the CLI.

Something like

latticejson show tree /path/to/lattice

But we have to discuss the scope of this repo (see #4). I would like to keep this repo independent of Python. So that this repo would only contain the CLI and the schema files. What is your opinion?

@TMsangohan
Copy link
Collaborator Author

In principle I agree with you that we should try to keep the repo independent of Python. But in that case how would you do the (elegant, ...) converters? You would, create a new repo (latticejsonPythonTools)?

@felix-andreas
Copy link
Member

What I meant with independent, this repo should only contain the definition and a tool to validate/convert lattice files. In which language this cli tool is implemented should be no concern to the user.

Then there should be a other repo which contains an Python API to load/save/manipulate lattice files. This should pylatticetools or apace (we have to discuss this) ...

@TMsangohan
Copy link
Collaborator Author

Ah ok I see.

Yes, let us discuss the pylatticetools soon. I am working on a similar tool (financejson), and I have similar concerns :). I'll send you a link to the tool soon (working on unit tests) and converters (Excel, HDF5, SQL, MongoDB, etc...).

@felix-andreas
Copy link
Member

fixed by #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants