Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert/remove element #4

Open
TMsangohan opened this issue Nov 24, 2019 · 2 comments
Open

Insert/remove element #4

TMsangohan opened this issue Nov 24, 2019 · 2 comments

Comments

@TMsangohan
Copy link
Collaborator

Should we include insert and remove functionality?

@felix-andreas
Copy link
Member

You mean to manipulate the lattice files in python?

I am not completely sure of the scope of this repository. I think the main purpose of this repo should be to specify/define the latticeJSON format and it should be independent of Python.

Even though the latticeJSON tool to validate/convert the lattice files is written in Python, I think this should only be an implementation detail (and no concern to the user).

The functionality to load lattice files into Python, manipulate them and save them is already implemented in apace.

The way is see it there are two options:

  1. We move the code of apace which can load/save/manipulate latticeJSON files to a seperate repo (e.g. named pylatticejson). Then apace and your tools would be user of this separate library.

  2. I have to design apace in such a way that it can be used as library by your and other tools.

A concern I have about the first approach is, that is it maybe a bit over-engineered and could be confusing to a user which has to import different libraries.

I would prefer the second approach, as I think it not so easy to complete separate the lattice-logic and from the rest of the code of apace. For example the signal system or the print_tree function. Would they belong to the pylatticejson library or to my apace code?

But if you have a strong opinion that there should be a separate python library, we can do this. But we have to discuss what belongs in there.

@TMsangohan
Copy link
Collaborator Author

Ok, sorry read issue #3 first. I'm not sure, the idea of a pylatticejson repo does not sound to bad to me. If we want to keep all the packages useful for other users, pylatticejson might not be a bad idea, maybe not every user needs the full apace functionalities? I think some general tools would go well in such a repo (read, insert, upsert, convert,...). Also how would you drop the Python dependence for the validation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants