Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use org-mode keymap as a parent to reuse binding #118

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

ag91
Copy link
Contributor

@ag91 ag91 commented Jan 5, 2022

This makes available the whole keybindings of Org mode even whern org-transclusion-mode is running.
The keybindings of org-transclusion override Org mode map (that's how keybinding inheritance works)

I followed the guide at
https://www.gnu.org/software/emacs/manual/html_node/elisp/Inheritance-and-Keymaps.html

because I really cannot enjoy an Org file without most of Org key
bindings available :)

Happy to close it if that is not what you want for your mode.

I followed the guide at
https://www.gnu.org/software/emacs/manual/html_node/elisp/Inheritance-and-Keymaps.html

because I really cannot enjoy an Org file without most of Org key
bindings available :)
@nobiot
Copy link
Owner

nobiot commented Jan 6, 2022

Thank for this!
Yes, I would like to apply your proposed change...

Have done FSF copyright assignment paperwork in the past?
If not, we have two options:

  1. As your contribution is less than 15 lines of code, with your permission, we can go ahead and apply your change as a "minor change". The 15-line guidance (rule?) seems to be for the cumulative total for any GNU project, so if you have contributed to other GNU projects before, that should be counted in, I think

  2. We can wait for you to go through the paperwork. If you wish to continue to make more contributions, this option might be a preferred one

Org-transclusion is published on ELPA, which means that any contributor with more than 15 lines of code will need to have signed the FSF copyright paperwork.
It's mentioned in Contributing section of README

Org-transclusion is part of GNU ELPA and thus copyrighted by the Free Software Foundation (FSF). This means that anyone who is making a substantive code contribution will need to “assign the copyright for your contributions to the FSF so that they can be included in GNU Emacs” (Org Mode website).

Copy link
Owner

@nobiot nobiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ag91
Copy link
Contributor Author

ag91 commented Jan 6, 2022 via email

@nobiot nobiot merged commit c49744b into nobiot:main Jan 6, 2022
@nobiot
Copy link
Owner

nobiot commented Jan 6, 2022

@ag91
The process is for any GNU project, including Emacs itself, Org, and all the packages available through GNU ELPA. It's stipulated and administered by the Free Software Foundation, so I don't think putting a template here on GH repo will be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants