Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PC-13028 Support Azure Monitor managed service for Prometheus in Direct #449

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat: PC-13028 Support Azure Monitor managed service for Prometheus in Direct #449

wants to merge 22 commits into from

Conversation

dawidwisn
Copy link
Contributor

@dawidwisn dawidwisn commented Jun 7, 2024 •
edited
Loading

Motivation

Support new integration with Azure Monitor managed service for Prometheus in Direct mode

Summary

New fields in Direct spec:

 spec:
    azurePrometheus: 
      url: ""
      tenantId: ""
      clientId: ""
      clientSecret: ""

Release Notes

Added Azure Monitor managed service for Prometheus Direct Spec extending v1alpha.Direct.Spec

Base automatically changed from PC-13027-support-for-azure-prometheus to main June 19, 2024 10:23
@dawidwisn dawidwisn changed the title PC-13028 Support direct in AzurePrometheus feat: PC-13028 Support Azure Monitor managed service for Prometheus in Direct Jun 19, 2024
@n9-machine-user n9-machine-user added enhancement New feature or request minor labels Jun 19, 2024
@dawidwisn dawidwisn marked this pull request as ready for review June 19, 2024 12:47
@paulina-n9
Copy link

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikodemrafalski nikodemrafalski nikodemrafalski approved these changes

@nieomylnieja nieomylnieja Awaiting requested review from nieomylnieja nieomylnieja is a code owner

@skrolikiewicz skrolikiewicz Awaiting requested review from skrolikiewicz skrolikiewicz is a code owner

@daniel-zelazny daniel-zelazny Awaiting requested review from daniel-zelazny daniel-zelazny is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request go minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dawidwisn @paulina-n9 @nikodemrafalski @n9-machine-user