Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
High Sierra support #727
The adafruit scanner seems to work on high sierra where LightBlue doesnt appear to be able to read characteristics.
You can play along at home if I missed your favorite xpcid. I used frida instead of swizzling, because I couldnt get swizzling to work. I think maybe the CBXpcConnection are now private and maybe they used to be public? but I had never done it before so it could be my failure.
and just poked around the Adafruit app then later painstakingly decoded the logs
I grabbed all the xpcids I could find from #689, but I wanted to keep a little better git hygiene so started fresh but credit due there.
Yes, this works on older versions too, this PR only adds support for a new version of MacOS, it doesn't affect previous versions.…
On Thu, Jan 25, 2018 at 11:41 AM, Philip van Allen ***@***.*** > wrote: Thanks for this! It works for me on High Sierra 10.13.2 communicating with an Arduino 101. Does it this PR work with earlier versions of macOS? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#727 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABH4B-hpCODwN3ZohQBZePapNo0d0STUks5tONjigaJpZM4RMdr7> .
Were seeing reports that people who use the isNotification flag are broken. It turns out Apple seems to have removed it and so the fix would seem to be downstream users rewriting their code not to depend on that flag.
and indeed isnotification looks to be gone from the mac apis
These guys have the runtime headers dumped for 10.12 and 10.13
clearly quite a few changes on cbcentralmanager anyway
but we dont seem to have cbperipheraldelegate headers? so cant see the diff there, though we clearly know it used to be there and is not now
i dont know that isnotifying was ever exposes on the offical api?
Maybe theres more little changes we havent seen yet (including new goodies).. It would be valuable look through this thoroughly
related, webbluetooth struggled with this for a while
Technically this is now a api breaking change and would mean a 2.0 release but I dont know how committed we are to semver for such a small break. From searching github this we think this 'functionality' is actually rarely used. anyway
I guess users and are probably pegged to ^1 and mac users are used to mac breaking (and indeed are broken right now) I dont feel bad about just shipping the breaking change of isNotification as undefined as a minor release. In the docs well say its deprecated (and indeed gone) as of high sierra
referenced this pull request
Jan 31, 2018
Jan 31, 2018
1 check was pending
This was referenced
Jan 31, 2018