High Sierra support #727

jacobrosenthal · 2017-12-26T02:59:45Z

The adafruit scanner seems to work on high sierra where LightBlue doesnt appear to be able to read characteristics.

You can play along at home if I missed your favorite xpcid. I used frida instead of swizzling, because I couldnt get swizzling to work. I think maybe the CBXpcConnection are now private and maybe they used to be public? but I had never done it before so it could be my failure.

For frida

$ frida-trace -m "-[CBXpcConnection sendMsg:args:]:"  -m "-[CBXpcConnection _handleMsg:]" *Adafruit*
Instrumenting functions...                                              
-[CBXpcConnection sendMsg:args:]: Loaded handler at "/Users/jacobrosenthal/__handlers__/__CBXpcConnection_sendMsg_args__.js"
-[CBXpcConnection _handleMsg:]: Loaded handler at "/Users/jacobrosenthal/__handlers__/__CBXpcConnection__handleMsg__.js"

You can see it autogenerated some javascript files we can use to inspect and debug
CBXpcConnection_sendMsg_args.js

{
  onEnter: function (log, args, state) {
    log("-[CBXpcConnection sendMsg:" + args[2].toString(10) + " args:" + args[3] + "]");
    if(args[3]){
          var obj = ObjC.Object(args[3]);
          log(obj.toString())
    }
  }
}

CBXpcConnection__handleMsg.js

{
  onEnter: function (log, args, state) {
    log("-[CBManager sendMsg:" + args[2] + " args:" + args[3] + "]");

    if(args[3]){
          var obj = ObjC.Object(args[3]);
          log(obj.toString())
    }
  }
}

and just poked around the Adafruit app then later painstakingly decoded the logs

I grabbed all the xpcids I could find from #689, but I wanted to keep a little better git hygiene so started fresh but credit due there.

Please test

closes #679

jacobrosenthal · 2017-12-26T04:49:21Z

lib/mac/highsierra.js

+ * @discussion The ids were incemented but there seems to be no CoreBluetooth function to call/verify this.
+ */
+nobleBindings.broadcast = function(deviceUuid, serviceUuid, characteristicUuid, broadcast) {
+  this.sendCBMsg(80, {


I dont have a good test case for broadcast. Anyone have a code. when I fire this call to 80 I dont get a response at all so this might be wrong.

jacobrosenthal · 2017-12-26T04:49:46Z

lib/mac/highsierra.js

+ * @discussion The ids were incemented but there seems to be no CoreBluetooth function to call/verify this.
+ */
+ //TODO
+nobleBindings.on('kCBMsgId73', function(args) {


This is still TODO. Cant confirm broadcast works so cant confirm what its return call would be.

sublimator · 2017-12-28T10:17:17Z

Thanks for this! Will report back test results

elafargue · 2018-01-07T22:37:01Z

Seems to be working fine on my Mac with High Sierra 10.13.2, thanks for this PR!

Any chance those can get merged at some point? I noticed there hasn't been a release on this package for a while...

elafargue · 2018-01-14T03:32:17Z

Is this project still actively maintained?

sublimator · 2018-01-14T04:24:54Z

We should all donate some $ somehow. Or put up some code.

jacobrosenthal · 2018-01-14T22:43:15Z

Broadcast code is still sort of in high sierra, but pretty deprecated. No one spoke up so I deleted it and that path has a throw in it to say the functionality is removed. I think this PR is as complete as our current level of user reporting will allow.

pvanallen · 2018-01-25T19:41:18Z

Thanks for this! It works for me on High Sierra 10.13.2 communicating with an Arduino 101. Does it this PR work with earlier versions of macOS?

jakerockland · 2018-01-25T19:52:18Z

This is working for us on High Sierra 10.13.1. Is there a plan for this to be merged soon?

elafargue · 2018-01-25T20:04:37Z

Yes, this works on older versions too, this PR only adds support for a new version of MacOS, it doesn't affect previous versions.

…

On Thu, Jan 25, 2018 at 11:41 AM, Philip van Allen ***@***.*** > wrote: Thanks for this! It works for me on High Sierra 10.13.2 communicating with an Arduino 101. Does it this PR work with earlier versions of macOS? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#727 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABH4B-hpCODwN3ZohQBZePapNo0d0STUks5tONjigaJpZM4RMdr7> .

vvo · 2018-01-26T08:34:16Z

This is working for me too

jacobrosenthal · 2018-01-28T18:01:51Z

Were seeing reports that people who use the isNotification flag are broken. It turns out Apple seems to have removed it and so the fix would seem to be downstream users rewriting their code not to depend on that flag.

yosemite-bindings xpcEvent: {
"kCBMsgId": 71,
"kCBMsgArgs": {
"kCBMsgArgCharacteristicHandle": 106,
"kCBMsgArgDeviceUUID": {
"type": "Buffer",
"data": [
6,
238,
186,
37,
182,
218,
65,
134,
157,
122,
163,
193,
146,
60,
106,
16
]
},
"kCBMsgArgData": {
"type": "Buffer",
"data": [
2
]
},
"kCBMsgArgIsNotification": 1
}
} +2s

highsierra-bindings xpcEvent: {
"kCBMsgId": 83,
"kCBMsgArgs": {
"kCBMsgArgCharacteristicHandle": 106,
"kCBMsgArgDeviceUUID": {
  "type": "Buffer",
  "data": [
    61,
    31,
    196,
    97,
    216,
    81,
    69,
    123,
    130,
    183,
    61,
    137,
    246,
    194,
    222,
    67
  ]
},
"kCBMsgArgData": {
  "type": "Buffer",
  "data": [
    2
  ]
}
}

https://developer.apple.com/library/content/releasenotes/MacOSX/WhatsNewInOSX/Articles/macOS_10_13_0.html#//apple_ref/doc/uid/TP40017638-SW1
"Updated the APIs in the Core Bluetooth framework to match across iOS, tvOS, watchOS, and macOS, and marked the platform availability of each API."

and indeed isnotification looks to be gone from the mac apis
https://developer.apple.com/documentation/corebluetooth/cbperipheraldelegate/1518708-peripheral

These guys have the runtime headers dumped for 10.12 and 10.13
https://github.com/onmyway133/Runtime-Headers/blob/master/macOS/

clearly quite a few changes on cbcentralmanager anyway
https://github.com/onmyway133/Runtime-Headers/blob/master/macOS/10.12/CoreBluetooth.framework/CBCentralManager.h
https://github.com/onmyway133/Runtime-Headers/blob/master/macOS/10.13/CoreBluetooth.framework/CBCentralManager.h

but we dont seem to have cbperipheraldelegate headers? so cant see the diff there, though we clearly know it used to be there and is not now

Hey neat:
http://codeworkshop.net/objc-diff/sdkdiffs/macos/10.13/CoreBluetooth.html

i dont know that isnotifying was ever exposes on the offical api?

Maybe theres more little changes we havent seen yet (including new goodies).. It would be valuable look through this thoroughly

related, webbluetooth struggled with this for a while
WebBluetoothCG/web-bluetooth#274

Technically this is now a api breaking change and would mean a 2.0 release but I dont know how committed we are to semver for such a small break. From searching github this we think this 'functionality' is actually rarely used. anyway

…ssibly being undefined It is also deprecated after release v1.8.1

jacobrosenthal · 2018-01-31T17:28:23Z

I guess users and are probably pegged to ^1 and mac users are used to mac breaking (and indeed are broken right now) I dont feel bad about just shipping the breaking change of isNotification as undefined as a minor release. In the docs well say its deprecated (and indeed gone) as of high sierra

vvo · 2018-02-02T12:29:13Z

Awesome!

vvo · 2018-02-02T12:30:35Z

I guess users and are probably pegged to ^1 and mac users are used to mac breaking (and indeed are broken right now) I dont feel bad about just shipping the breaking change of isNotification as undefined as a minor release. In the docs well say its deprecated (and indeed gone) as of high sierra

@jacobrosenthal Do you mean there's no way to get notifications like the issue you chipped in at voodootikigod/node-rolling-spider#103 (comment)?

Thanks!

jacobrosenthal · 2018-02-02T15:38:06Z

Theres no longer any way to know if its a notification or a response to a manual read request

duplicate yosemite for high sierra bindings

34645cc

jacobrosenthal mentioned this pull request Dec 26, 2017

Tracking macOS High Sierra Support #679

Closed

jacobrosenthal commented Dec 26, 2017

View reviewed changes

vikeri mentioned this pull request Jan 9, 2018

Added support for MacOS HighSierra #689

Closed

jacobrosenthal force-pushed the highsierra branch from 317ecbb to 8c9acfb Compare January 14, 2018 21:53

jacobrosenthal added 2 commits January 15, 2018 09:35

high sierra xpc ids

ebbce24

examples: serviceData is array so stringify to print

3468683

jacobrosenthal force-pushed the highsierra branch from 6d62631 to 3468683 Compare January 15, 2018 16:35

noble deleted a comment from andrewjaykeller Jan 30, 2018

sandeepmistry changed the title ~~(complete?) High Sierra support~~ High Sierra support Jan 31, 2018

Add note on isNotification parameter for characteristic data event po…

1517989

…ssibly being undefined It is also deprecated after release v1.8.1

sandeepmistry mentioned this pull request Jan 31, 2018

Don't fire characteristicvaluechanged for Read Responses WebBluetoothCG/web-bluetooth#274

Open

sandeepmistry approved these changes Jan 31, 2018

View reviewed changes

sandeepmistry merged commit 38dd42e into noble:master Jan 31, 2018

This was referenced Jan 31, 2018

State = unknown on BLE supported mac #728

Closed

Using Noble on Raspberry Pi 3 doesnt work vs. on Mac #698

Closed

drandreas mentioned this pull request Jun 10, 2018

Mojave support #804

Closed

geovie mentioned this pull request Sep 18, 2018

Use official CoreBluetooth API #828

Open

geovie mentioned this pull request Nov 9, 2018

Native mac bindings #840

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

High Sierra support #727

High Sierra support #727

jacobrosenthal commented Dec 26, 2017 •

edited

Loading

jacobrosenthal Dec 26, 2017

jacobrosenthal Dec 26, 2017

sublimator commented Dec 28, 2017

elafargue commented Jan 7, 2018

elafargue commented Jan 14, 2018

sublimator commented Jan 14, 2018 via email

jacobrosenthal commented Jan 14, 2018

pvanallen commented Jan 25, 2018

jakerockland commented Jan 25, 2018 •

edited

Loading

elafargue commented Jan 25, 2018 via email

vvo commented Jan 26, 2018

jacobrosenthal commented Jan 28, 2018 •

edited

Loading

jacobrosenthal commented Jan 31, 2018

vvo commented Feb 2, 2018

vvo commented Feb 2, 2018

jacobrosenthal commented Feb 2, 2018

High Sierra support #727

High Sierra support #727

Conversation

jacobrosenthal commented Dec 26, 2017 • edited Loading

jacobrosenthal Dec 26, 2017

Choose a reason for hiding this comment

jacobrosenthal Dec 26, 2017

Choose a reason for hiding this comment

sublimator commented Dec 28, 2017

elafargue commented Jan 7, 2018

elafargue commented Jan 14, 2018

sublimator commented Jan 14, 2018 via email

jacobrosenthal commented Jan 14, 2018

pvanallen commented Jan 25, 2018

jakerockland commented Jan 25, 2018 • edited Loading

elafargue commented Jan 25, 2018 via email

vvo commented Jan 26, 2018

jacobrosenthal commented Jan 28, 2018 • edited Loading

jacobrosenthal commented Jan 31, 2018

vvo commented Feb 2, 2018

vvo commented Feb 2, 2018

jacobrosenthal commented Feb 2, 2018

jacobrosenthal commented Dec 26, 2017 •

edited

Loading

jakerockland commented Jan 25, 2018 •

edited

Loading

jacobrosenthal commented Jan 28, 2018 •

edited

Loading