Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalina support #907

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Catalina support #907

wants to merge 6 commits into from

Conversation

lzever
Copy link

@lzever lzever commented Oct 11, 2019

modify most MsgId

@chazguerrero
Copy link

can you add the missing semi colon so the build works?

add missing semi colon to mark build works
old version cause "The command "if [ $NODE_VERSION == "0.8" ]; then npm install -g npm@2; fi" failed and exited with 1 during ."
@jlubeck
Copy link

jlubeck commented Dec 4, 2019

This works like a charm

@gad0lin
Copy link

gad0lin commented Dec 9, 2019

Discovering devices, characteristics, services works but reading characteristic hangs. Any luck with reading?

I found that reading works with https://github.com/jnross/Bluetility, but it's not that obvious how to reverse engineer it.

I have tried luck with loop in read but no results:

nobleBindings.read = function(deviceUuid, serviceUuid, characteristicUuid) {
  for (let i =0; i < 100; i++) {
    console.log('trying reading ', i) 
  this.sendCBMsg(i , {
    kCBMsgArgDeviceUUID: this._peripherals[deviceUuid].uuid,
    kCBMsgArgCharacteristicHandle: this._peripherals[deviceUuid].services[serviceUuid].characteristics[characteristicUuid].handle,
    kCBMsgArgCharacteristicValueHandle: this._peripherals[deviceUuid].services[serviceUuid].characteristics[characteristicUuid].valueHandle
  });
}
};

discoverDescriptors also hangs...

minor thing... line 5 should be changed from

var debug         = require('debug')('mojave-bindings');

to

var debug         = require('debug')('catalina-bindings');

@gad0lin
Copy link

gad0lin commented Dec 9, 2019

This solves issue of reading from characteristics without it you can't read from BLE on Catalina. Fixing issue required finding valid magic number for reading, which is 110.

I did pull request to pull request: lzever#1 :)

Here is the fork with the fix:
https://github.com/gad0lin/noble

@eugef
Copy link

eugef commented Jan 19, 2020

If you have issues with latest versions of Node.js or MacOS, you can consider using https://github.com/abandonware/noble instead!
It is a fork of this project which is actively maintained.

@rzr
Copy link

rzr commented Feb 20, 2020

Please forward change to downstream fork:
#923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants