[WIP] Fix build on node 10.x #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix comes from #84 (comment) , so I can't personally vouch for it.
This was referenced Jun 18, 2018
|
Thanks for this. To get it to work i had to edit the package.json path lib/notify.js to start with ../ |
|
lib/notify where? |
|
Oops, sorry. I meant lib/native.js. Took this from a commit in kounch's repo. |
|
I'll add that, but I'm also working on a massive refactoring of the repo. |
|
done |
|
Thanks! |
|
Неплохо бы уже заиметь поддержку десятой ноды, да. |
|
It worked for me, but I had to disable parallel building: Probably not related to that patch. |
|
This is affecting "usb" module too, workaround is: This patch would be welcome in next release: |
|
Are there any news? Last is one month ago ... when it is planned to be available? |
|
meanwhile this can be forked into npm 'org namespace do you recommend any ? |
|
Node 10 has now reached LTS status, is there any official fix coming? |
|
I think sandeep is just too busy to properly maintain noble. I'm using my own typescriptified fork of noble instead. |
|
So single maintenance model can be transferred to co-maintenance ? Any opinion on @sandeepmistry on this suggestion? |
|
Please merge :( |
rzr
pushed a commit
to abandonware/node-bluetooth-hci-socket
that referenced
this pull request
Dec 14, 2018
This fix comes from noble#84 (comment) , so I can't personally vouch for it. Change-Id: Ifde2a3b996ab89a4b12b0eb155c081aca2b11dc3 Origin: https://github.com/jrobeson/node-bluetooth-hci-socket Forwarded: noble#91
rzr
pushed a commit
to abandonware/node-bluetooth-hci-socket
that referenced
this pull request
Dec 14, 2018
Change-Id: Ide752983f00395cf8cb59ab727a58ff0692112dd Origin: https://github.com/jrobeson/node-bluetooth-hci-socket Forwarded: noble#91
rzr
added a commit
to abandonware/node-bluetooth-hci-socket
that referenced
this pull request
Dec 19, 2018
Might be caused by parallel jobs? ``` > @abandonware/bluetooth-hci-socket@0.5.3-0 install /local/home/philippe/var/cache/url/git/ssh/github.com/tizenteam/node-bluetooth-hci-socket/src/node-bluetooth-hci-socket > node-pre-gyp install --fallback-to-build (...) Release/obj.target/binding/src/BluetoothHciSocket.o: file not recognized: File truncated collect2: error: ld returned 1 exit status (...) ``` Or ``` rm: cannot remove './Release/.deps/Release/obj.target/binding/src/BluetoothHciSocket.o.d.raw': No such file or directory (...) make: *** [Release/obj.target/binding/src/BluetoothHciSocket.o] Error 1 ``` Origin: https://github.com/abandonware/node-bluetooth-hci-socket/pulls Relate-to: noble#91 Change-Id: I34726c8adffc7c39f585f42da1f7d776c5761a17 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to abandonware/node-bluetooth-hci-socket
that referenced
this pull request
Dec 19, 2018
Might be caused by parallel jobs? ``` > @abandonware/bluetooth-hci-socket@0.5.3-0 install /local/home/philippe/var/cache/url/git/ssh/github.com/tizenteam/node-bluetooth-hci-socket/src/node-bluetooth-hci-socket > node-pre-gyp install --fallback-to-build (...) Release/obj.target/binding/src/BluetoothHciSocket.o: file not recognized: File truncated collect2: error: ld returned 1 exit status (...) ``` Or ``` rm: cannot remove './Release/.deps/Release/obj.target/binding/src/BluetoothHciSocket.o.d.raw': No such file or directory (...) make: *** [Release/obj.target/binding/src/BluetoothHciSocket.o] Error 1 ``` Origin: #4 Relate-to: noble#91 Change-Id: I34726c8adffc7c39f585f42da1f7d776c5761a17 Signed-off-by: Philippe Coval <p.coval@samsung.com>
This was referenced Nov 2, 2019
rzr
added a commit
to abandonware/node-bluetooth-hci-socket
that referenced
this pull request
Jan 24, 2020
Might be caused by parallel jobs? ``` > @abandonware/bluetooth-hci-socket@0.5.3-0 install /local/home/philippe/var/cache/url/git/ssh/github.com/tizenteam/node-bluetooth-hci-socket/src/node-bluetooth-hci-socket > node-pre-gyp install --fallback-to-build (...) Release/obj.target/binding/src/BluetoothHciSocket.o: file not recognized: File truncated collect2: error: ld returned 1 exit status (...) ``` Or ``` rm: cannot remove './Release/.deps/Release/obj.target/binding/src/BluetoothHciSocket.o.d.raw': No such file or directory (...) make: *** [Release/obj.target/binding/src/BluetoothHciSocket.o] Error 1 ``` Origin: #4 Relate-to: noble#91 Change-Id: I34726c8adffc7c39f585f42da1f7d776c5761a17 Signed-off-by: Philippe Coval <p.coval@samsung.com>
|
Feel free to comment this related ticket: |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix comes from
#84 (comment)
, so I can't personally vouch for it.