Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced path pose parameter with return value. #136

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Replaced path pose parameter with return value. #136

merged 1 commit into from
Mar 17, 2022

Conversation

lewie-donckers
Copy link
Contributor

Next PR to fix #123 .

Refactored Controller::findPositionOnPlan(): replaced path_pose_idx output parameter with (part of) the return value.

@lewie-donckers lewie-donckers self-assigned this Mar 16, 2022
@lewie-donckers lewie-donckers added the refactor Refactor request label Mar 16, 2022
rokusottervanger
rokusottervanger requested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@rokusottervanger rokusottervanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the single comment, I approve!

include/path_tracking_pid/controller.hpp Show resolved Hide resolved
@lewie-donckers lewie-donckers mentioned this pull request Mar 17, 2022
Merged
Base automatically changed from fix/123-cleanup-update to main March 17, 2022 11:46
@cesar-lopez-mar cesar-lopez-mar self-requested a review March 17, 2022 11:56
@lewie-donckers lewie-donckers merged commit 13aad0a into main Mar 17, 2022
@lewie-donckers lewie-donckers deleted the fix/123-replace-path-pose-parameter branch March 17, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rayman Rayman Rayman approved these changes

@rokusottervanger rokusottervanger rokusottervanger approved these changes

@cesar-lopez-mar cesar-lopez-mar cesar-lopez-mar approved these changes

@Timple Timple Awaiting requested review from Timple

Assignees

@lewie-donckers lewie-donckers

Labels
refactor Refactor request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller::findPositionOnPlan() should be refactored
4 participants
@lewie-donckers @Rayman @rokusottervanger @cesar-lopez-mar