Skip to content

Commit

Permalink
Merge pull request #27 from nobrainr/Fix/remove-lodash-dep
Browse files Browse the repository at this point in the history
Fix/remove lodash dep
  • Loading branch information
emyann committed Sep 23, 2018
2 parents fb73437 + 4582cfc commit 6a950a4
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 36 deletions.
28 changes: 1 addition & 27 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,52 +10,26 @@ jobs:
working_directory: ~/repo
steps:
- checkout
# Download and cache dependencies
- restore_cache:
keys:
- v1-dependencies-{{ checksum "package-lock.json" }}
# fallback to using the latest cache if no exact match is found
- v1-dependencies-
- run: npm install
- run: npm run build
- run: npm test
- save_cache:
paths:
- node_modules
- packages/cli
key: v1-dependencies-{{ checksum "package-lock.json" }}
test-job-10:
docker:
- image: circleci/node:10-browsers
working_directory: ~/repo
steps:
- checkout
# Download and cache dependencies
- restore_cache:
keys:
- v1-dependencies-{{ checksum "package-lock.json" }}
# fallback to using the latest cache if no exact match is found
- v1-dependencies-
- run: npm install
- run: npm run build
- run: npm test
- save_cache:
paths:
- node_modules
- packages/cli
key: v1-dependencies-{{ checksum "package-lock.json" }}

publish-job:
docker:
- image: circleci/node:10
working_directory: ~/repo
steps:
- checkout
- restore_cache:
keys:
- v1-dependencies-{{ checksum "package-lock.json" }}
# fallback to using the latest cache if no exact match is found
- v1-dependencies-
- run: npm install
- run:
name: Pre-Publish Script
command: ./tools/publish.sh
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ app/
node_modules/
src/build/
coverage/
*-debug.log

2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
}
},
"packages": ["packages/*"],
"version": "0.2.6"
"version": "0.3.1"
}
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"main": "src/index.ts",
"scripts": {
"build": "lerna bootstrap",
"update-cli-in-e2e": "lerna add create-ts-lib packages/e2e",
"test": "cd packages/e2e && npm test",
"publish": "lerna run publish-cli"
},
Expand Down
7 changes: 6 additions & 1 deletion packages/cli/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions packages/cli/template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,5 @@
"webpack-cli": "^3.1.0",
"webpack-dev-server": "^3.1.5"
},
"dependencies": {
"lodash": "^4.17.4"
}
"dependencies": {}
}
4 changes: 1 addition & 3 deletions packages/cli/template/src/MyLibrary.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import { random } from 'lodash';

export interface Foo {
executeDependency: Function;
}

export class MyLibrary implements Foo {
executeDependency() {
return random(0, 10);
return Math.floor(Math.random() * 10 + 1);
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"test": "create-ts-lib app && cd app && npm run build && npm run test"
},
"dependencies": {
"create-ts-lib": "^0.2.6",
"create-ts-lib": "^0.3.1",
"rimraf": "^2.6.2"
},
"keywords": [],
Expand Down

0 comments on commit 6a950a4

Please sign in to comment.