Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply rewrite. #4

Closed
noccu opened this issue Jan 29, 2019 · 0 comments
Closed

Supply rewrite. #4

noccu opened this issue Jan 29, 2019 · 0 comments
Assignees
@noccu
Labels
enhancement New/improved feature or request help wanted Extra attention is needed
Projects
Supply & planner updates

Comments

@noccu
Copy link
Owner

noccu commented Jan 29, 2019

Currently Supplies is divided in treasure and consumables types ("kinds"). It came to my attention that the crate page provides a list, though incomplete, of item_kinds provided by the game which seemingly provides all data required for using them, as well as occasional type keys in responses for items which are not included in the list.

It would be real nice to adopt this for use in Veera and I have thus started on it already.
But Supply underlies many parts of the extension so it's a bit of an undertaking and will progress slowly, potentially hindering other changes or new features. Hence this issue is largely to contain info, discussion, reference, and collaborate.
@noccu noccu added enhancement New/improved feature or request help wanted Extra attention is needed labels Jan 29, 2019
@noccu noccu self-assigned this Jan 29, 2019
@noccu noccu added this to In progress in Supply & planner updates Jan 29, 2019
@noccu noccu mentioned this issue Feb 1, 2019
Closed
noccu added a commit that referenced this issue Feb 6, 2019
@noccu
Fix a warning regarding item data.
e8f08e2 
Add farm locations to commonly used treasure tooltips. (partial data, possibly temporary, requires visiting supplies in-game once and then reloading Veera)
Moving towards the wiki milestone, could be seen as part of #1.
Also of note for #4.
Fix planner not showing some items (broke in 966e2a0, oops!)
@noccu noccu mentioned this issue Mar 11, 2019
Closed
@noccu noccu closed this as completed in 52de497 Mar 13, 2019
Supply & planner updates automation moved this from In progress to Done Mar 13, 2019
noccu added a commit that referenced this issue Mar 28, 2019
@noccu
Supply updates. Merge supply events into one.
9cb6085 
Effect is all supply types are now sent to the UI and thus visible.
Refining on #4.

- setTreasure and setConsumables -> updSupplies
- Add a "get all" function
- Move initializing supplies UI out of the load function, into main.
noccu added a commit that referenced this issue Mar 28, 2019
@noccu
Update planner UI to deal with supply changes.
0f0ea98 
Should have been part of #4 but I completely forgot about it.

- Planner items should update real-time again.
- All types of items should show. (no actual change)
- Styling should work properly.
- Add a generic list update function as part of this
  - Make raids use it as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noccu noccu

Labels
enhancement New/improved feature or request help wanted Extra attention is needed
Projects
No open projects
Supply & planner updates
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noccu