Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client fails to detect some digs #263

Closed
dooglus opened this issue Dec 13, 2015 · 1 comment
Closed

client fails to detect some digs #263

dooglus opened this issue Dec 13, 2015 · 1 comment

Comments

@dooglus
Copy link
Collaborator

dooglus commented Dec 13, 2015

The client keeps track of "digsupply", but gets it wrong in the event that a single transaction digs up two 4.6 outputs that were created in the same transaction.

For example, 2abba6a64b0409fe064b5ca6be712e556e1096659a242b48e16a25db7b97831d outputs 86 and 161 were both first moved as f76339adf1d73901daf9ef8e66fa0a090093fc6b2f56b3fa1960cfb484f97317 inputs 41 and 42. The client only notices input 41, and not input 42.

The dig detection code in CTransaction::FetchInputs() needs to move from the 1st to the 2nd loop over the inputs, since the first loop is only making sure the transactions can be loaded, and skips any 2nd or later inputs from a single transaction.

dooglus added a commit that referenced this issue Dec 13, 2015
Fix #263; count all digs, even if two or more are dug from the same t…
@dooglus
Copy link
Collaborator Author

dooglus commented Dec 14, 2015

It appears the first such instance of this happening was in block 17982:

old 17981:   "digsupply" : 6157.49432438,
new 17981:   "digsupply" : 6157.49432438,

old 17982:   "digsupply" : 7599.00197100,
new 17982:   "digsupply" : 7612.81833822,

http://khashier.com/tx/f76339adf1d73901daf9ef8e66fa0a090093fc6b2f56b3fa1960cfb484f97317, mentioned in OP is in that block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant