Skip to content

Commit

Permalink
style: prettier (#1311)
Browse files Browse the repository at this point in the history
  • Loading branch information
paulmelnikow authored and gr2m committed Sep 4, 2019
1 parent ccac7c7 commit d8913b3
Show file tree
Hide file tree
Showing 64 changed files with 9,688 additions and 8,680 deletions.
14 changes: 7 additions & 7 deletions .eslintrc.yml
Expand Up @@ -5,15 +5,15 @@ parserOptions:
ecmaVersion: 9

extends:
- "eslint:recommended"
- 'eslint:recommended'
- prettier

rules:
# Override some recommended rules.
no-unused-vars: ["error", {"args": "none"}]
no-empty: ["error", { "allowEmptyCatch": true }]
no-unused-vars: ['error', { 'args': 'none' }]
no-empty: ['error', { 'allowEmptyCatch': true }]

strict: ["error", "safe"]
no-loop-func: "error"
no-trailing-spaces: "error"
eol-last: "error"
strict: ['error', 'safe']
no-loop-func: 'error'
no-trailing-spaces: 'error'
eol-last: 'error'
5 changes: 2 additions & 3 deletions .github/ISSUE_TEMPLATE/01_bug_report.md
@@ -1,7 +1,6 @@
---
name: 🐛 Bug report
about: If something isn't working 🤕

---

**What is the expected behavior?**
Expand All @@ -12,7 +11,7 @@ about: If something isn't working 🤕

**How to reproduce the issue**

Runkit: *[Example link](https://runkit.com/gr2m/node-nock-nock-768)*
Runkit: _[Example link](https://runkit.com/gr2m/node-nock-nock-768)_

_Having problem producing a test case? Try and ask the community for help. If the test case cannot be reproduced, the Nock community might not be able to help you._

Expand All @@ -21,6 +20,6 @@ _Having problem producing a test case? Try and ask the community for help. If th
**Versions**

| Software | Version(s) |
|----------|------------|
| -------- | ---------- |
| Nock | |
| Node | |
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/02_feature_request.md
@@ -1,7 +1,6 @@
---
name: 🚀 Feature request
about: Let us know if you have a feature request 💡

---

**Context**
Expand Down
14 changes: 0 additions & 14 deletions .github/ISSUE_TEMPLATE/03_support.md
@@ -1,24 +1,10 @@
---
name: ❓ Support
about: If you need support, check out Nock on StackOverflow

---

<!-- 👆 Click "Preview" for a nicer view! -->














We primarily use GitHub as an issue tracker; for usage and support questions we primairly use StackOverflow. Please tag the questions with `nock` so the community can easily find it. [Go to StackOverflow](https://stackoverflow.com/questions/tagged/nock).

If you want to submit a feature request you can do that [here](https://github.com/nock/nock/issues/new?template=feature_request.md) or bug reports [here](https://github.com/nock/nock/issues/new?template=bug_report.md).
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/04_thanks.md
@@ -1,7 +1,6 @@
---
name: ❤️ Say thank you
about: Tell us how you use nock & support our efforts in maintaining Nock

---

# ❤️ I'm using Nock
Expand Down
6 changes: 3 additions & 3 deletions .istanbul.yml
@@ -1,5 +1,5 @@
instrumentation:
excludes: ['tests/**/*.js', 'examples/**/*.js', 'lib/recorder.js']
excludes: ['tests/**/*.js', 'examples/**/*.js', 'lib/recorder.js']
check:
global:
lines: 90
global:
lines: 90
20 changes: 10 additions & 10 deletions CODE_OF_CONDUCT.md
Expand Up @@ -8,19 +8,19 @@ In the interest of fostering an open and welcoming environment, we as contributo

Examples of behavior that contributes to creating a positive environment include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a professional setting
- The use of sexualized language or imagery and unwelcome sexual attention or advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic address, without explicit permission
- Other conduct which could reasonably be considered inappropriate in a professional setting

## Our Responsibilities

Expand Down
20 changes: 10 additions & 10 deletions CONTRIBUTING.md
Expand Up @@ -10,11 +10,11 @@ Please note that this project is released with a [Contributor Code of Conduct](.

- [Commit Message conventions](#commit-message-conventions)
- [Beta / Next / Maintenance releases](#beta--next--maintenance-releases)
* [Backport a fix / feature to a previous version](#backport-a-fix--feature-to-a-previous-version)
* [Submit a Beta / Next release](#submit-a-beta--next-release)
- [Backport a fix / feature to a previous version](#backport-a-fix--feature-to-a-previous-version)
- [Submit a Beta / Next release](#submit-a-beta--next-release)
- [Generate README TOC](#generate-readme-toc)
- [Running tests](#running-tests)
* [Airplane mode](#airplane-mode)
- [Airplane mode](#airplane-mode)
- [Release Process](#release-process)
- [GitHub Apps](#github-apps)
- [Becoming a maintainer](#becoming-a-maintainer)
Expand Down Expand Up @@ -43,7 +43,7 @@ three commit message conventions need to be followed

- Commit bug fixes with `fix: ...` or `fix(scope): ...` prefix in commit subject
- Commit new features with `feat: ...` or `feat(scope): ...` prefix in commit subject
- Commit breaking changes by adding `BREAKING CHANGE: ` in the commit body
- Commit breaking changes by adding `BREAKING CHANGE:` in the commit body
(not the subject line)

Other helpful conventions are
Expand Down Expand Up @@ -122,12 +122,12 @@ Nock is actively interested in having more maintainers. That means that we would

Here are some things you can do today to actively show the Nock team that you're interested in helping out in the long term:

* **Triage issues!** We have more issues than we have bandwidth to deal with. For some of these issues, there are no labels, no comments suggesting how the issue could be resolved, and no follow-up after months or years of silence. It would be great if the issues actively reflected the state of the project. Go through old issues and suggesting labels in comments, ask for more information, and generally help out with the resolution process. This would be a great help!
* **Review PRs.** We have a lot of open PRs! Some of these are probably ready to merge, and some of them probably need more work. Any extra eyes on PRs are encouraged. Comment on code patterns you think need work, suggest extra tests, and let us know if a PR 'LGTM' ("looks good to me"). The more reviewers we have, the faster we can merge issues, the better this project becomes.
* **Help out!** If someone files a bug and no one has responded yet, see if you can resolve it! Suggest PRs, or file them yourself. While most contributors are going to only be interested in their own bugs, great maintainers help out with other people's bugs. This is one of the best ways to become an expert at Nock (and Node.js, JavaScript, or pretty much any project) - helping others.
* **Write docs.** Are our docs missing something important? Are they not clear? Could they be better? Open a PR!
* **Suggest examples.** Right now, we have a few examples, but we could always have more. Submit small example files and tutorials. At some point, we'll have to work on a better way to display these - for now, it's great to show others how to solve difficult mocking problems easily with Nock.
* **Refactor.** This is one of the hardest things to do, but one of the most useful. Go through the code, and find examples where it could be written better - with better variable names, more useful abstractions, and more elegant patterns. Taking away ten lines of code that are unnecessary is more valuable than submitting a hundred new lines, sometimes. Open a PR or a comment and defend your position; ask for feedback.
- **Triage issues!** We have more issues than we have bandwidth to deal with. For some of these issues, there are no labels, no comments suggesting how the issue could be resolved, and no follow-up after months or years of silence. It would be great if the issues actively reflected the state of the project. Go through old issues and suggesting labels in comments, ask for more information, and generally help out with the resolution process. This would be a great help!
- **Review PRs.** We have a lot of open PRs! Some of these are probably ready to merge, and some of them probably need more work. Any extra eyes on PRs are encouraged. Comment on code patterns you think need work, suggest extra tests, and let us know if a PR 'LGTM' ("looks good to me"). The more reviewers we have, the faster we can merge issues, the better this project becomes.
- **Help out!** If someone files a bug and no one has responded yet, see if you can resolve it! Suggest PRs, or file them yourself. While most contributors are going to only be interested in their own bugs, great maintainers help out with other people's bugs. This is one of the best ways to become an expert at Nock (and Node.js, JavaScript, or pretty much any project) - helping others.
- **Write docs.** Are our docs missing something important? Are they not clear? Could they be better? Open a PR!
- **Suggest examples.** Right now, we have a few examples, but we could always have more. Submit small example files and tutorials. At some point, we'll have to work on a better way to display these - for now, it's great to show others how to solve difficult mocking problems easily with Nock.
- **Refactor.** This is one of the hardest things to do, but one of the most useful. Go through the code, and find examples where it could be written better - with better variable names, more useful abstractions, and more elegant patterns. Taking away ten lines of code that are unnecessary is more valuable than submitting a hundred new lines, sometimes. Open a PR or a comment and defend your position; ask for feedback.

Once you've been around for a bit, ask a current Maintainer - one of [the team members](https://github.com/orgs/nock/people) - whether you can be elevated to Maintainer status and given permissions to close issues and merge PRs. We're interested in how well you know what Nock is about, and how involved you are in the community - not where you're from, how good your English is, or whether or not you can pass a whiteboard test blindfolded. If you think that you've been helpful, let us know. We're friendly, promise. :)

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTORS.md
Expand Up @@ -969,7 +969,7 @@ narendra @reddynr https://github.com/reddynr
@zacharyscott https://github.com/zacharyscott
@zeevl https://github.com/zeevl
psixdev @PsiXdev https://github.com/PsiXdev
t__hos @TomHoss https://github.com/TomHoss
t\_\_hos @TomHoss https://github.com/TomHoss
taevas @zyvas https://github.com/zyvas
taven @taven-liu https://github.com/taven-liu
wang yu @wayoo https://github.com/wayoo
Expand Down

0 comments on commit d8913b3

Please sign in to comment.