Skip to content

Commit

Permalink
refactor(restoreOverriddenRequests): Eliminate uncovered line
Browse files Browse the repository at this point in the history
  • Loading branch information
paulmelnikow authored and gr2m committed May 2, 2019
1 parent fb21929 commit ef5ecbc
Showing 1 changed file with 11 additions and 19 deletions.
30 changes: 11 additions & 19 deletions lib/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const isUtf8Representable = function(buffer) {
}

// Array where all information about all the overridden requests are held.
let requestOverride = []
let requestOverrides = {}

/**
* Overrides the current `request` function of `http` and `https` modules with
Expand All @@ -81,14 +81,14 @@ const overrideRequests = function(newRequest) {
const overriddenRequest = module.request
const overriddenGet = module.get

if (requestOverride[moduleName]) {
if (requestOverrides[moduleName]) {
throw new Error(
`Module's request already overridden for ${moduleName} protocol.`
)
}

// Store the properties of the overridden request so that it can be restored later on.
requestOverride[moduleName] = {
requestOverrides[moduleName] = {
module,
request: overriddenRequest,
get: overriddenGet,
Expand Down Expand Up @@ -125,23 +125,15 @@ const overrideRequests = function(newRequest) {
*/
const restoreOverriddenRequests = function() {
debug('restoring requests')

// Restore any overridden requests.
_(requestOverride)
.keys()
.each(function(proto) {
Object.entries(requestOverrides).forEach(
([proto, { module, request, get }]) => {
debug('- restoring request for', proto)

const override = requestOverride[proto]
// TODO-coverage: `override` is always truthy. Refactor to eliminate the
// uncovered line.
if (override) {
override.module.request = override.request
override.module.get = override.get
debug('- restored request for', proto)
}
})
requestOverride = []
module.request = request
module.get = get
debug('- restored request for', proto)
}
)
requestOverrides = {}
}

/**
Expand Down

0 comments on commit ef5ecbc

Please sign in to comment.