'method' property not available on superagent mocked requests

[mrijke]

What is the expected behavior?
The property 'method' should be available on a request from superagent, similar to here:
https://runkit.com/mrijke/superagent-with-method-on-request

What is the actual behavior?
The 'method' property is undefined

Possible solution
Copy the value from the 'method' property, if available (i.e. the request came from superagent)

How to reproduce the issue

https://runkit.com/mrijke/nock-superagent-undefined-method

Does the bug have a test case?
No, but the superagent specific testcase can be extended, e.g.

test('superagent works', t => {
  const responseText = 'Yay superagent!'
  const headers = { 'Content-Type': 'text/plain' }
  nock('http://example.test')
    .get('/somepath')
    .reply(200, responseText, headers)

  superagent.get('http://example.test/somepath').end(function(err, res) {
    t.equal(res.text, responseText)
    t.equal(res.req.method, "get") // <-- added assert here
    t.end()
  })
})

Versions

Software	Version(s)
Nock	10.0.6
Node	10.15.3

[paulmelnikow]

Hi! Thanks for the report. Does this problem exist in 11.x as well? I'm guessing yes?

[mrijke]

@paulmelnikow Yes, I tried updating my runkit to 11.0.0-beta.14 and the issue is still there.

[paulmelnikow]

Awesome. Thanks!

To you, or anyone else: we'd welcome a PR with a fix and an isolated test!

A note on the testing strategy: we're moving away from preventing regression of integration problems using wide-bracket integration tests (#1427). So we should instead add a test which isolates the specific client behavior, and be added to the client-facing tests in https://github.com/nock/nock/blob/beta/tests/test_request_overrider.js.

The integration test can (and even should) be used to confirm the fix at the time of the change, but won't be kept in the main nock codebase.

We're also open to contributions on #1427 toward building up and maintaining separate client integration tests which test against the latest development versions of Nock.

[mastermatt]

This was fixed with #1561