-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP2 support #1625
Comments
I'm not familiar with HTTP2 yet. Am I correct that this would require extending both the mock surface (#1606) and the developer-facing API? |
Yup, the mock surface needs to be extended for sure. The developer-facing API... not really. |
Maybe we'll have the HTTP/1.1 mock surface better segregated by the time you're ready to look at this! |
fwiw, there's also this 👉 https://github.com/bcoe/http2spy |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions. |
Has there been any progress on this/is it on the roadmap for future versions of nock? |
The maintainers work on Nock in their free time and we don’t maintain a roadmap of new features. If someone is interested in making this addition we’re happy to try to help get it merged. |
If I may add, I think a discussion or RFC on what the API would look like to support HTTP2 might be a good first step before an actual implementation PR. I know the fundamentals of HTTP2, but I don't use it day to day, and I don't think Nock's current API is sufficient. The concept of server-push alone has some gotchas when testing from the client-side. |
Context
HTTP2 is the new standard and it looks very promising.
Alternatives
There are no alternatives yet.
Has the feature been requested before?
Nope.
If the feature request is accepted, would you be willing to submit a PR?
Currently I'm busy with
http2-wrapper
(HTTP2, just with the usual HTTP1 API). It depends. If you want me to do it now, I can't. If you let me do it a month later, sure.The text was updated successfully, but these errors were encountered: