Readable event broken due to improper stream implementation.

[tlivings]

The following would break when parsing an http request in nock:

res.on('readable', function() {
  var chunk;
  while (null !== (chunk = res.read())) {
    console.log('got %d bytes of data', chunk.length);
  }
});

This is because nock doesn't seem to send null to indicate the stream is complete as per the specification here:

The read() method pulls some data out of the internal buffer and returns it. If there is no data available, then it will return null.

[pgte]

Landed on v0.36.2

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!