-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for 'readable' event. #146
Comments
Are there any plans to add support for this? |
If you provide a unit test that fails with this issue, I would try to fix it. |
I see you gave an example on the other thread. I'll check it out when I get some time. |
Great. Thank you very much. |
@jbergknoff I've just created PR #175 with a fix for this. If you want to test it on your end before it gets merged into master you can find it in fix-146 branch. |
Seems like your change fixes my issue. Thanks, @ierceg. |
Great, tnx for letting me know. On Mon, May 19, 2014 at 7:01 PM, jbergknoff notifications@github.comwrote:
|
I may have spoken too soon -- still seeing issues elsewhere in my test suite. They may have a different cause. I will update when I understand better. |
Ok, tnx. |
Opened a new issue regarding this: #193 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
If an http client parses data on
readable
event rather thandata
, nock fails.The text was updated successfully, but these errors were encountered: