Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nock delay not working when timeout value defined in agent instead of in request itself #2296

Closed
2 tasks done
codinbox opened this issue Feb 3, 2022 · 1 comment · Fixed by #2297
Closed
2 tasks done

Comments

@codinbox
Copy link

codinbox commented Feb 3, 2022

Please avoid duplicates

Reproducible test case

https://runkit.com/codinbox/nock-delay

Nock Version

13.2.2

Node Version

16.13.0

TypeScript Version

No response

What happened?

When using nock to test timeout with .delay() function, if request timeout not set but agent timeout, the delay does not work.

If timeout is define in request options, delay() function works and a timeout is triggered.

Nock does not check agent timeout when request timeout does not exist.

Would you be interested in contributing a fix?

  • yes
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

🎉 This issue has been resolved in version 13.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant