allowUnmocked causes no requests to match when query is specified

[robinbobbitt]

var nock=require('nock'),
request=require('request');

nock('https://www.google.com', 
    { allowUnmocked: true })
    .log(console.log)
    .get("/abc")
    .query({'user':'fred'})
    .reply(200, "Match!")

request('https://www.google.com/abc?user=fred', function (error, response, body) {
    if (!error && response.statusCode == 200) {
        console.log(body);
    } else{
        console.log(error ? "error: " + error : "response.statusCode: "+ response.statusCode);
    }
});

With the code above, my request does NOT match and goes to google.com.
$ node nockTest.js
response.statusCode: 404

By changing allowUnmocked to false, I get:

$ node nockTest.js
matching https://www.google.com:443?user=fred to GET https://www.google.com:443/abc with query({"user":"fred"}): true
Match!

I am able to work around this and keep allowUnmocked=true by using a filteringPath to remove the query. Is this a bug or am I missing something here? Thanks!

[pgte]

@robinbobbitt sounds like a bug around the behavior dependent on allowUnmocked being true.

[Elergy]

Yes, when we have allowUnmocked:true, request is mocked when it exactly matches to url we passed to get.

For example, this variant gives us expected result.

let nock=require('nock');
let request=require('request');

nock('https://www.google.com',
    { allowUnmocked: true })
    .get('/abc?user=fred')
    .reply(200, 'Match!');

request('https://www.google.com/abc?user=fred', (error, response, body) => {
    if (!error && response.statusCode == 200) {
        console.log('response: ' + body);
    } else {
        console.log(error ? 'error: ' + error : 'response.statusCode: ' + response.statusCode);
    }
});

But if we pass to get something different, like RegEx, Function, string with path without parameters, we'll fail.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!