Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepEqualExtended is broken #731

Closed
mickaeltr opened this issue Oct 24, 2016 · 4 comments · Fixed by singapore/gl-got#11
Closed

deepEqualExtended is broken #731

mickaeltr opened this issue Oct 24, 2016 · 4 comments · Fixed by singapore/gl-got#11

Comments

@mickaeltr
Copy link

A regression appeared in 8.2.0 and #719.
deepEqualExtended now fails when "spec" is null or undefined:

Uncaught TypeError: Cannot read property 'constructor' of null
at deepEqualExtended (…/node_modules/nock/lib/match_body.js:60:50)
      at deepEqualExtended (…/node_modules/nock/lib/match_body.js:63:12)
      at deepEqualExtended (…/node_modules/nock/lib/match_body.js:63:12)
      at Object.matchBody (…/node_modules/nock/lib/match_body.js:53:10)
      at Interceptor.match (…/node_modules/nock/lib/interceptor.js:325:30)
@RobertWHurst
Copy link
Contributor

This seems to happen when a request body contains an empty object.

@RobertWHurst
Copy link
Contributor

I've created a PR to fix the regression. It can be found here => #734

@vrinek vrinek closed this as completed in a67fe14 Oct 28, 2016
@mickaeltr
Copy link
Author

Thanks!

@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants