Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle arrays like objects in match_body #719

Merged
merged 1 commit into from
Oct 16, 2016
Merged

Handle arrays like objects in match_body #719

merged 1 commit into from
Oct 16, 2016

Conversation

ltegman
Copy link
Contributor

@ltegman ltegman commented Oct 11, 2016

Closes #715 and does not appear to cause any regressions.

@coveralls
Copy link

coveralls commented Oct 11, 2016 •
edited

Coverage Status

Coverage remained the same at 96.542% when pulling af583e4 on ltegman:fix/body-spec-regex-in-array into bc565eb on node-nock:master.

vrinek
vrinek suggested changes Oct 11, 2016
View reviewed changes
Copy link
Contributor

@vrinek vrinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks god. Would you mind adding a couple of tests regarding this?

@vrinek
Copy link
Contributor

vrinek commented Oct 11, 2016

*Code looks good (damn autocorrect)

@ltegman ltegman force-pushed the fix/body-spec-regex-in-array branch from af583e4 to c4c5689 Compare October 13, 2016 04:03
@ltegman
Copy link
Contributor Author

ltegman commented Oct 13, 2016

I added a test covering this. One layer of array should be enough, since that was all it took to cause the problem, but I'm happy to add a more complex test case if you'd like.

@coveralls
Copy link

coveralls commented Oct 13, 2016 •
edited

Coverage Status

Coverage increased (+0.004%) to 96.547% when pulling c4c5689 on ltegman:fix/body-spec-regex-in-array into bc565eb on node-nock:master.

@vrinek vrinek merged commit 4a266e8 into nock:master Oct 16, 2016
@vrinek
Copy link
Contributor

vrinek commented Oct 16, 2016

Thanks for the contribution 😄

@vrinek
Copy link
Contributor

vrinek commented Oct 23, 2016 •
edited

Published as part of v8.2.0 🎉

@mickaeltr mickaeltr mentioned this pull request Oct 24, 2016
Closed
@RobertWHurst
Copy link
Contributor

I've created a PR to fix the regression. It can be found here => #734

vrinek added a commit that referenced this pull request Oct 28, 2016
@vrinek
Merge pull request #734 from RobertWHurst/master
15b4d27 
Fixes regression introduced by #719
vrinek added a commit that referenced this pull request Oct 28, 2016
@vrinek
Merge pull request #734 from RobertWHurst/master
a716ea0 
Fixes regression introduced by #719
@renovate-bot renovate-bot mentioned this pull request Feb 13, 2017
Merged
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrinek vrinek vrinek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ltegman @coveralls @vrinek @RobertWHurst @aredridel @mickaeltr