Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify request body matching on README #1101

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Conversation

albertogasparin
Copy link
Contributor

Closes #982

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so good thanks a lot! I just have one minor comment, otherwise good to go

README.md Outdated
.reply(200, { id: '123ABC' });
```

In case you need to perform a partial matching on a complex, nested request body you should have a look at libraries like `lodash.matches`. Indeed, partial matching can be achieved as:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you link lodash.matches to https://lodash.com/docs/#matches?

@albertogasparin
Copy link
Contributor Author

Updated 😉

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 💐

@gr2m gr2m merged commit c1c403e into nock:master Mar 15, 2018
@nockbot
Copy link
Collaborator

nockbot commented Apr 9, 2018

🎉 This PR is included in version 9.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants