Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(overrider): unmocked HTTPS request with partial interceptor match #1664

Merged
merged 1 commit into from
Aug 14, 2019

Commits on Aug 8, 2019

  1. bug(overrider): unmocked HTTPS request with partial interceptor match

    Fixes: nock#1422
    
    The `allowUnmocked` option is processed in two places. Once in the
    intercept when there are no interceptors that come close to matching
    the request. And again in the overrider when there are interceptors
    that partially match, eg just path, but don't completely match.
    
    This fixes and explicitly tests the later case in the overrider by
    making an HTTPS request for a path that has an interceptor but fails to
    match the query constraint.
    mastermatt committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    a59b2a1 View commit details
    Browse the repository at this point in the history