refactor: replace LoDash isPlainObject, mapValues, and isMap #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
approved these changes
Mar 28, 2020
| while (Object.getPrototypeOf(proto) !== null) { | ||
| proto = Object.getPrototypeOf(proto) | ||
| } | ||
| return Object.getPrototypeOf(value) === proto |
There was a problem hiding this comment.
This seems more complex than necessary, though it’s definitely not a breaking change. I’m fine with it.
There was a problem hiding this comment.
The related LD PR lodash/lodash#3483.
|
@paulmelnikow I swapped out |
- `isMap` was added to `util.types` in Node 10.0. https://nodejs.org/api/util.html#util_util_types_ismap_value - `isPlainObject` and `mapValue` both came from LoDash's master branch, which is the pending v5. - Replace LoDash dependency with `lodash.set` to cover the one use we still have. Ref: nock#1285
mastermatt
force-pushed
the
1285/isplainobject-mapvalue
branch
from
7303e86
to
b85f914
Compare
paulmelnikow
approved these changes
Mar 30, 2020
|
🎉 This PR is included in version 13.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 13.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 13.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tusbar
reviewed
Jun 29, 2020
| @@ -24,7 +24,7 @@ | |||
| "dependencies": { | |||
| "debug": "^4.1.0", | |||
| "json-stringify-safe": "^5.0.1", | |||
| "lodash": "^4.17.13", | |||
| "lodash.set": "^4.3.2", | |||
There was a problem hiding this comment.
These mono-function lodash packages are deprecated.
They should not be used – and they will be removed in v5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isMapwas added toutil.typesin Node 10.0https://nodejs.org/api/util.html#util_util_types_ismap_value
isPlainObjectandmapValueboth came from LoDash's master branch, which is the pending v5.Ref: #1285