-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using AbortSignal to abort requests #2479
Conversation
Any chance that this could be reviewed / merged please? It's causing us issues when testing code that uses |
Sorry that the current nock version still supports Node 10 😞 We are working on support for the native fetch as our priority, we will probably bump the minimal node version to 18 as part of that |
Hi @gr2m , thanks so much for getting back to me! I'm pretty sure it's only the tests that don't run on earlier versions of Node but I quite understand if you want to hang fire on this until the native |
Had to use this fork to test a request deduplication fn using abortController code in jest tests for FE 🙏 to merge. (node 18 + jest unit test) |
Maybe we can merge this for the |
I changed head and updated the PR with latest changes from the |
(this looks awesome - came here looking to see why my timeouts weren't working on the beta branch, and this would do it!) |
Now the beta supports this case :) This is closed in favor of #2760, which adds the tests. |
See #2478
Problem
AbortSignal
nock
currently has no support for thisSolution