Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isomorphic fetch usage with basicAuth/matchHeader #822

Merged
merged 3 commits into from
Feb 10, 2017
Merged

Fix isomorphic fetch usage with basicAuth/matchHeader #822

merged 3 commits into from
Feb 10, 2017

Conversation

unstubbable
Copy link
Contributor

This adds a toString() in matchStringOrRegexp to fix the usage of matchHeader and basicAuth together with isomorphic fetch.

@coveralls
Copy link

coveralls commented Feb 9, 2017 •
edited

Coverage Status

Coverage decreased (-0.03%) to 96.545% when pulling 933cbad on KingHenne:fix/isomorphic-fetch-basic-auth into 1d1cafc on node-nock:master.

@unstubbable
Copy link
Contributor Author

unstubbable commented Feb 9, 2017 •
edited

The coverage decreased because the test files are covered as well. Your should probably exclude them in the nyc config. (fixed in #823)

@ianwsperber ianwsperber self-requested a review February 9, 2017 18:21
@ianwsperber ianwsperber added this to the 9.0.5 milestone Feb 9, 2017
@ianwsperber
Copy link
Contributor

Thanks for the PR @KingHenne, I will take a look at this tomorrow

@ianwsperber
Copy link
Contributor

LGTM, great work @KingHenne!!! Should have this released within the day

@ianwsperber ianwsperber merged commit 86babe8 into nock:master Feb 10, 2017
@unstubbable unstubbable deleted the fix/isomorphic-fetch-basic-auth branch February 10, 2017 18:04
@renovate-bot renovate-bot mentioned this pull request Feb 13, 2017
Merged
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianwsperber ianwsperber Awaiting requested review from ianwsperber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unstubbable @coveralls @ianwsperber