Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Redo all necessary DNS records reverted by other PRs #65

Closed
jimbrig opened this issue May 11, 2024 · 6 comments
Closed

[Bug]: Redo all necessary DNS records reverted by other PRs #65

jimbrig opened this issue May 11, 2024 · 6 comments
Assignees
Labels
breaking Indicates a breaking chance that affects existing code bug Something isn't working config Configuration Management help wanted Extra attention is needed

Comments

@jimbrig
Copy link
Member

jimbrig commented May 11, 2024

@phoward38 when you merged the various pull requests (#59 #60 #61 #62 #63 and #64), you removed all the work I did yesterday for some pretty advanced DNS records.

For example, in PR #59 's DNSControl GitHub Workflow Preview Output:

image

Notice that the following changes occurred:

  • The spf (TXT) record got modified adding two additional, unecessary domains: amazonses.com and stripe.com; we only need _spf.google.com)
  • The CAA record for issuing certificated from https://letsencrypt.org got deleted - this is necessary for providing HTTPS support for the needed mta-sts.noclocks.dev sub-domain which hosted the MTS-STS policy file.
  • CNAME record changed from hixie to pixie (not sure about this one)
  • other modified TXT records
  • modified _dmarc TXT policy record which was how we wanted it to be
  • Deleted the new _mta-sts record which is needed
  • Deleted the github pages verification record which is needed
  • Not sure about the new testimonials sub-domain? what is senja.io?

I will create issues and PRs and re-do everything.

@jimbrig jimbrig added breaking Indicates a breaking chance that affects existing code bug Something isn't working config Configuration Management help wanted Extra attention is needed labels May 11, 2024
@phoward38
Copy link
Member

@jimbrig I can redo it since I removed them. Not sure how that happened since I didn't touch those records.

@jimbrig
Copy link
Member Author

jimbrig commented May 11, 2024

No worries I've got it all locally on my other laptop and will re-implement adding docs as I go

@jimbrig
Copy link
Member Author

jimbrig commented May 11, 2024

Going to add testing suite against the records also with an automated GHA workflow and merge protection to help in the future also

@jimbrig
Copy link
Member Author

jimbrig commented May 14, 2024

@phoward38 can you provide insights into the following from above?

1. CNAME record changed from hixie to pixie (not sure about this one)

DNS Lookups:

2. Not sure about the new testimonials sub-domain? what is senja.io?

Not seeing this anymore as the current record is:

// CNAME Records - Testimonials
, CNAME("testimonials", "cname.testimonial.to.")

but if you look at your commit from the development pull request, you'll see that's where it got changed initially and was in turn reverted back here.

Copy link
Member

phoward38 commented May 14, 2024

  • @jimbrig that commit was accidental.
    • I did set up an account for us at Senja; it's free plan includes a lot (don't think Testimonials.to is worth the $20/month, especially w/ the website still being developed): https://senja.io/p/noclocks/r/testimonials
    • I'm going to create similar Testimonials components to add to our site ourselves
  • I'm not sure about the hixie/lixie update

Copy link
Member Author

jimbrig commented May 15, 2024

Cool

@jimbrig jimbrig closed this as completed by moving to Done in Internal - Infrastructure May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Indicates a breaking chance that affects existing code bug Something isn't working config Configuration Management help wanted Extra attention is needed
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants