fix(data-template): fix title input prevented proper data switching #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aotemj
pushed a commit
to aotemj/nocobase
that referenced
this pull request
May 29, 2023
…ocobase#1937) * fix(data-template): fix title input prevented proper data switching * fix: build error * fix: clear the previous data before switching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (Bug 描述)
如下图所示，如果先输入
模板标题会导致其它选项异常。Steps to reproduce (复现步骤)
模板标题数据表模板数据还是保持原样，并没有跟着数据表切换Expected behavior (预期行为)
模板标题都不影响其它选项的正常使用Actual behavior (实际行为)
复现步骤Related issues (相关 issue)
Reason (原因)
模板标题的时候破环了原有数据的响应性，导致数据变更之后 UI 没有刷新Solution (解决方案)
DataTemplateTitle组件中修改onChange和onBlur的监听方法，防止破环数据的响应性。具体变动请看：https://github.com/nocobase/nocobase/pull/1937/files?diff=split&w=0