Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for client #1960

Merged
merged 59 commits into from
Jun 7, 2023
Merged

test: add tests for client #1960

merged 59 commits into from
Jun 7, 2023

Conversation

zhangzhonghe
Copy link
Contributor

@zhangzhonghe zhangzhonghe commented May 31, 2023 •
edited

Description (需求描述)

  • 每一个前端组件都应该有测试用例，以提高功能稳定性
  • 每一个 hook 都应该有测试用例

Motivation (需求背景)

  • 前端功能不稳定，测试成本及代码复现成本高昂
  • 添加功能或修改代码时心里没有底，没有一个可靠的反馈机制
  • 缓解人工测试压力，自动化相关流程

Key changes (关键改动）

  • Frontend (前端)
    • 无功能性改动
    • 仅是添加测试代码
  • Backend (后端)
    • 无改动

Test plan (测试计划)

Suggestions (测试建议)

  • 理论上无需人工测试

Underlying risk (潜在风险)

  • 理论上无任何风险

Showcase (结果展示）

进行中。。。

TODO

  • 修复 Vitest 运行报错
  • 迁移 nocobase-next 仓库测试代码
  • 补充剩余组件测试用例
  • 补充 hooks 测试用例

@zhangzhonghe zhangzhonghe force-pushed the zzh/test branch 5 times, most recently from 944ca7f to 87281d3 Compare June 6, 2023 05:47
@hongboji hongboji added the solved label Jun 6, 2023
@chenos
Copy link
Contributor

chenos commented Jun 6, 2023

Link T-288

@height
Copy link

height bot commented Jun 6, 2023 •
edited

This pull request has been linked to 1 task:

💡Tip: Add "Close T-288" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

chenos
chenos requested changes Jun 6, 2023
View reviewed changes
packages/core/test/src/index.ts Outdated Show resolved Hide resolved
@zhangzhonghe
fix: fix CI
36ce3ff
@zhangzhonghe
test(FormItem): add test
023bfdb
@zhangzhonghe
test(FormV2): add test
90b1581
@zhangzhonghe
test(G2Plot): add test
638cd4c
@zhangzhonghe
test(Gantt): add test
4c7f9ed
@zhangzhonghe
test(Grid): add test
2daafd1
@zhangzhonghe
test(GridCard): add test
a87cd19
@zhangzhonghe
test(Kanban): add test
04cda5e
@zhangzhonghe
test(List): add test
e5a3edb
@zhangzhonghe
test(Menu): add test
f93ffbc
@zhangzhonghe
test(Page): add test
cebd29f
@zhangzhonghe
test(Pagination): add test
3c30337
@zhangzhonghe
test(Preview): add test
34e104f
@zhangzhonghe
test(RemoteSelect): add test
832944c
@zhangzhonghe
test: fix: failed
68c0398
@zhangzhonghe
refactor: remove useless code
895fcda
@zhangzhonghe
test(Table): add test
9108f1b
@zhangzhonghe
test(TableV2): add test
f6d405e
@zhangzhonghe
test(Tabs): add test
a6f8308
@zhangzhonghe
test(Variable): add test
147eecc
@zhangzhonghe
test(Upload): add test
b0e016e
@zhangzhonghe
chore: comment
e5b5577
@zhangzhonghe
Revert "refactor: change require to import"
9a8fd0f 
This reverts commit 3a23607.
@zhangzhonghe
refactor: remove useless code
b9ab5d7
@zhangzhonghe
fix: fix translation bug
a199807
@zhangzhonghe
fix: fix export position
a206ec8
@zhangzhonghe
test: update snap
6400a3a
@zhangzhonghe zhangzhonghe merged commit 4783888 into main Jun 7, 2023
4 checks passed
@zhangzhonghe zhangzhonghe deleted the zzh/test branch June 7, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenos chenos chenos requested changes

Assignees
No one assigned
Labels
solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhangzhonghe @chenos @hongboji