Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: List block and GridCard block style improve #1988

Merged
merged 10 commits into from
Jun 14, 2023
Merged

Conversation

katherinehhh
Copy link
Contributor

@katherinehhh katherinehhh commented Jun 6, 2023

Note
This is a template for submitting a new feature. Use the bug fix template if you're submitting a bug fix pull request by adding template=bug_fix.md to your pull request URL.

Description (需求描述)

优化list 区块和网格卡片区块样式

Motivation (需求背景)

Explain the reason for adding or modifying this feature.

Key changes (关键改动)

Provide a technically detailed description of the key changes made.

  • Frontend (前端)
  1. InternalListBlockProvider
    2.InternalGridCardBlockProvider
  • Backend (后端)

Test plan (测试计划)

Suggestions (测试建议)

Provide any suggestions or recommendations for improvements in the testing plan.

Underlying risk (潜在风险)

Identify any potential risks or issues that may arise from the new feature or modification.

Showcase (结果展示)

优化前:

image
image
image

优化后:

image
image
image

@height
Copy link

height bot commented Jun 6, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-228" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@katherinehhh katherinehhh changed the title refactor: list block and gridCard style improve refactor: List block and GridCard block style improve Jun 6, 2023
@chenos
Copy link
Contributor

chenos commented Jun 6, 2023

Link T-228

@chenos chenos merged commit c4816c6 into main Jun 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants