Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-fm): add option for storage to remove file physically or not #2005

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

mytharcher
Copy link
Contributor

Description (需求描述)

Add option for storage to remove file physically or not when destroy attachment record.

Motivation (需求背景)

The files in storage will not be deleted after attachment record destroyed. And this is a feature request (#1786).

Key changes (关键改动)

  • Frontend (前端)
    • Add paranoid option in storage form.
  • Backend (后端)
    • Add deletion logics for all builtin storages.

Test plan (测试计划)

Suggestions (测试建议)

By test cases.

Underlying risk (潜在风险)

TX-COS not tested due to no account.

Showcase (结果展示)

image

@height
Copy link

height bot commented Jun 7, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-245" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@mytharcher mytharcher merged commit 0c150ea into main Jun 7, 2023
17 checks passed
@mytharcher mytharcher deleted the T-245 branch June 7, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant