fix(client): fix json input component value handling #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to 1 task:
|
Dunqing
pushed a commit
that referenced
this pull request
Jun 12, 2023
* fix(client): fix json input component value handling * fix(client): fix json input test case * refactor(client): remove format button from json variable component * refactor(client): move json input style to global * test(client): remove unused test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (Bug 描述)
JSON input component content not updated after new value from props.
Steps to reproduce (复现步骤)
Expected behavior (预期行为)
JSON field should be with the value from data template.
Actual behavior (实际行为)
Value is empty.
Related issues (相关 issue)
N/A.
Reason (原因)
JSONInputis not usingvalueprop to react the changing value, due to legacy implementation for validation.Solution (解决方案)
Use uncontrolled value controlling, with
useState,useEffect, and only invokeonChangeinonBlurphase.