Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix designer button does not appear #2120

Merged
merged 2 commits into from
Jun 26, 2023
Merged

fix: fix designer button does not appear #2120

merged 2 commits into from
Jun 26, 2023

Conversation

zhangzhonghe
Copy link
Contributor

Description (Bug 描述)

Steps to reproduce (复现步骤)

  1. 非编辑状态 下刷新页面
  2. 切换到 编辑状态
  3. 会发现顶部和侧边栏的菜单按钮的 Designer Button 没有显示

Expected behavior (预期行为)

显示 Designer Button

Actual behavior (实际行为)

没有显示 Designer Button

Related issues (相关 issue)

Reason (原因)

useMemo 中没有依赖 Designer 导致 Designer 变更时 items 值没有更新。

Solution (解决方案)

useMemo 中依赖 Designer 即可。

@height
Copy link

height bot commented Jun 25, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-637" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@zhangzhonghe zhangzhonghe changed the title T 637 fix: fix designer button does not appear Jun 25, 2023
@zhangzhonghe zhangzhonghe merged commit ffcf9d2 into main Jun 26, 2023
4 checks passed
@zhangzhonghe zhangzhonghe deleted the T-637 branch June 26, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant