Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-workflow): change to formv2 to avoid values updating issue #2124

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

mytharcher
Copy link
Contributor

Description (Bug 描述)

After re-enter workflow canvas page, the schedule trigger config is not same as submitted before. But after reload whole page it will be correct.

Steps to reproduce (复现步骤)

  1. Add a schedule type workflow.
  2. Modify the trigger configurations and submit.
  3. Re-open the trigger configurations panel: correct.
  4. Go back to workflows list (browser history back).
  5. Re-enter the workflow canvas page submitted before.
  6. Open the trigger configurations panel: wrong.
  7. Reload page, open the trigger configurations panel: correct.

Expected behavior (预期行为)

After history go back and forward, the trigger config should be correct in panel as submitted.

Actual behavior (实际行为)

The config remains as old.

Related issues (相关 issue)

None.

Reason (原因)

Legacy Form component in schema component does not handle values correctly.

Solution (解决方案)

Migrate to FormV2 to fix.

@height
Copy link

height bot commented Jun 26, 2023

This pull request has been linked to 1 task:

  • T-427 工作流定时任务触发器时间设置需要刷新浏览器才能够看见 (unlink task)

💡Tip: Add "Close T-427" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@mytharcher mytharcher merged commit 6d80593 into main Jun 26, 2023
4 checks passed
@mytharcher mytharcher deleted the T-427 branch June 26, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants