Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): refactor variable components and variables in workflow #2157

Merged
merged 23 commits into from
Jul 5, 2023

Conversation

mytharcher
Copy link
Contributor

@mytharcher mytharcher commented Jun 30, 2023

Description (需求描述)

Refactor variable components and variables in workflow.

Motivation (需求背景)

Collection fields in variable components will cause performance issues when level is too deep.

Key changes (关键改动)

  • Frontend (前端)
    • Variable components
    • Collection fields variable lazy loading
  • Backend (后端)

Test plan (测试计划)

Suggestions (测试建议)

All variable scenarios in frontend.

Underlying risk (潜在风险)

  • Lazy load for unavailable fields association will show an arrow first, and the arrow will disappear after clicked.

Showcase (结果展示)

@height
Copy link

height bot commented Jun 30, 2023

This pull request has been linked to 4 tasks:

  • T-450 变量选择组件的是否能选中间级需要增加可配置项 (unlink task)
  • T-451 表达式、变量选择可以选择中间对象节点导致很多错误,优化加载的内容必须选择到末级节点 (unlink task)
  • T-815 历史条件判断选择节点数据报错白屏 (unlink task)
  • T-754 计算节点选择动态表达式有性能问题 (unlink task)

💡Tip: Add "Close T-450" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@mytharcher
Copy link
Contributor Author

mytharcher commented Jun 30, 2023

Link T-450 T-451.

@mytharcher mytharcher merged commit c9b7269 into main Jul 5, 2023
4 checks passed
@mytharcher mytharcher deleted the T-754 branch July 5, 2023 14:01
Dunqing pushed a commit that referenced this pull request Jul 6, 2023
…low (#2157)

* refactor(plugin-workflow): change collection variables to lazy load

* fix(plugin-workflow): avoid to-many reverse loading for association field

* fix(client): fix variable components

* chore(client): fix type

* fix(client): fix current user lazy load options

* refactor(client): remove compile from variable components which potencially causing bug

* fix(plugin-workflow): fix scope argument for new api

* fix(client): fix constant type options

* fix(client): fix infinity rerendering

* fix: avoid closure problem

* fix(client): should use no children when lazy load

* refactor(client): refactor AssignedField to use Variable component

* fix(client): fix type

* fix(plugin-workflow): fix variable options in some node not changes

* fix(plugin-workflow): fix select variable for operand crash (T-815)

* fix(plugin-workflow): variable types detect

* fix(plugin-workflow): detect association to match types

* fix(plugin-workflow): fix variable type filter logic

* fix(plugin-workflow): fix optional types

* fix(plugin-workflow): make changeOnSelect configurable in TextArea and JSONInput

---------

Co-authored-by: Rairn <958414905@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants