-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(client): refactor variable components and variables in workflow #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to 4 tasks:
|
Link T-450 T-451. |
…cially causing bug
Dunqing
pushed a commit
that referenced
this pull request
Jul 6, 2023
…low (#2157) * refactor(plugin-workflow): change collection variables to lazy load * fix(plugin-workflow): avoid to-many reverse loading for association field * fix(client): fix variable components * chore(client): fix type * fix(client): fix current user lazy load options * refactor(client): remove compile from variable components which potencially causing bug * fix(plugin-workflow): fix scope argument for new api * fix(client): fix constant type options * fix(client): fix infinity rerendering * fix: avoid closure problem * fix(client): should use no children when lazy load * refactor(client): refactor AssignedField to use Variable component * fix(client): fix type * fix(plugin-workflow): fix variable options in some node not changes * fix(plugin-workflow): fix select variable for operand crash (T-815) * fix(plugin-workflow): variable types detect * fix(plugin-workflow): detect association to match types * fix(plugin-workflow): fix variable type filter logic * fix(plugin-workflow): fix optional types * fix(plugin-workflow): make changeOnSelect configurable in TextArea and JSONInput --------- Co-authored-by: Rairn <958414905@qq.com>
This was referenced Jul 6, 2023
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (需求描述)
Refactor variable components and variables in workflow.
Motivation (需求背景)
Collection fields in variable components will cause performance issues when level is too deep.
Key changes (关键改动)
Test plan (测试计划)
Suggestions (测试建议)
All variable scenarios in frontend.
Underlying risk (潜在风险)
Showcase (结果展示)